| Summary: | The log level is different at same messages. | ||
|---|---|---|---|
| Product: | Tomcat 5 | Reporter: | Suzuki Yuichiro <suzuki.yuichiro> |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | ||
| Priority: | P5 | ||
| Version: | 5.5.20 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
Fixe din svn for 5.5.x and 6.0.x. Thanks for the report. |
I suggest a little message improvement. The log level is different at same messages. The message "Servlet.service() for servlet {0} threw exception" is output in eight places, but the message level is not same. --org.apache.catalina.core.ApplicationDispatcher#invoke ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), rootCause); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); --org.apache.catalina.core.StandardWrapperValve#invoke container.getLogger().warn(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); ... container.getLogger().warn(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); ... container.getLogger().error(sm.getString("standardWrapper.serviceException", wrapper.getName()), rootCause); ... container.getLogger().error(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); Are there any reasons for using getLogger().warn()? I think it would be better that all of them use getLogger().error(...).