Summary: | SSI regular expressions parsing fails | ||
---|---|---|---|
Product: | Tomcat 7 | Reporter: | David Reitter <david.reitter> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | david.reitter |
Priority: | P2 | ||
Version: | 7.0.39 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Attachments: |
test cases 1, 2 and 3
Another variant without =~ and without $1 |
Description
David Reitter
2013-07-01 17:08:30 UTC
Couple of issues here. 1. '=~' is perl RE syntax. That isn't what httpd uses in this case and Tomcat is aiming to emulate httpd. The expected syntax is '=' 2. You'll need the enhancement from bug 53387 to be implemented before your test will work. I'm therefore going to resolve this as a duplicate of 53387. *** This bug has been marked as a duplicate of bug 53387 *** Created attachment 30515 [details]
Another variant without =~ and without $1
Point 1: =~ is used in only one place in the test cases, and it is not what is causing this. See text of my bug report. Attaching foo2.html to demonstrate. Point 2: $1 is not what is causing this. See text of my bug report. Attaching foo2.html to demonstrate. foo2.html brings up the same two errors without use of =~ or $1. Sorry if my earlier test case contained these extra features. Re-opening to look at the new test cases. Found the root cause. '=' inside a regular expression was not handled correctly. There are also a bunch of other characters that would have triggered similar failures. This has been fixed in trunk and 7.0.x and will be included in 7.0.42 onwards. Thanks for the test cases. I used a simplified version to create a couple of unit tests. Nice, thank you. That was certainly quick. |