| Summary: | Tidy up use of TestElement.ENABLED; use TestElement.isEnabled()/setEnabled() throughout | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | Sebb <sebb> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | P2 | ||
| Version: | 2.9 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
URL: http://svn.apache.org/r1521971 Log: Tidy up use of TestElement.ENABLED; use TestElement.isEnabled()/setEnabled() throughout Bugzilla Id: 55548 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeModel.java jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeNode.java jmeter/trunk/xdocs/changes.xml This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3232 |
public void setEnabled(boolean enabled) was added to AbstractTestElement (for use by ProxyControl); it should also be added to the interface TestElement. Then it can be used elsewhere. There are also various uses of code like: if (component.getProperty(TestElement.ENABLED) instanceof NullProperty || component.getPropertyAsBoolean(TestElement.ENABLED)) { } This is exactly what AbstractTestElement.isEnabled() does, so the code could be simplifed to: if (component.isEnabled()) { }