Summary: | RealmBase#hasRole() imposes too much boilerplate code if principal is not of type GenericPrincipal | ||
---|---|---|---|
Product: | Tomcat 8 | Reporter: | Michael Osipov <michaelo> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | 8.5.x-trunk | ||
Target Milestone: | ---- | ||
Hardware: | All | ||
OS: | All |
Description
Michael Osipov
2016-12-12 13:20:19 UTC
I disagree, it's not worth changing the API for it and it's worse than "checking for changes" which actually never happens. BTW, this is an "enhancement", not a "major" bug. (In reply to Remy Maucherat from comment #1) > I disagree, it's not worth changing the API for it and it's worse than > "checking for changes" which actually never happens. > BTW, this is an "enhancement", not a "major" bug. Why do you close this issue without having a discussion first? No one is changing the API. You can still continue to override #hasRole(), it will have the same effect. The change can happen and are not a part of an API at at all. The code of RealmBase#hasRole() is implementation specific, not to be known to the user at best. Anyone else care to share an opinion on that? Feel free to post a patch. I think it's a reasonable change. (In reply to Christopher Schultz from comment #4) > Feel free to post a patch. I think it's a reasonable change. Thanks, I will prepare one next week. Fixed in: - trunk for 9.0.0.M18 onwards - 8.5.x for 8.5.12 onwards (In reply to Mark Thomas from comment #6) > Fixed in: > - trunk for 9.0.0.M18 onwards > - 8.5.x for 8.5.12 onwards Per(In reply to Mark Thomas from comment #6) > Fixed in: > - trunk for 9.0.0.M18 onwards > - 8.5.x for 8.5.12 onwards Perfect, couldn't be better. Thank you! |