Bug 41319 - URLRewritingModifier : Allow Parameter value to be url encoded
Summary: URLRewritingModifier : Allow Parameter value to be url encoded
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 2.2
Hardware: Other other
: P2 normal with 1 vote (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-08 11:15 UTC by bugmenot
Modified: 2014-07-19 21:06 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bugmenot 2007-01-08 11:15:04 UTC 
We are having issues with the URLRewritingModifier functionality.  We are trying
to rewrite form parameters that have plus signs in them.  Unfortunately, the
parameter is getting url decoded before it is submitted for the next page.

So for example:
hello+all

gets submitted as
hello all

on the subsequent page.

I've been able to fix the problem by modifying URLRewritingModifier.java and
changing:
sampler.getArguments().addArgument(new HTTPArgument(getArgumentName(), value,
true));


to:
sampler.getArguments().addArgument(new HTTPArgument(getArgumentName(), value,
false));


and this has resolved the issue.  However, this may break parameters retrieved
from the url itself.  My suggestion would be to have a checkbox to indicate
whether it is a form parameter or not and create the new argument appropriately.
Comment 1 Philippe Mouawad 2014-07-19 20:37:28 UTC 
Date: Sat Jul 19 20:30:58 2014
New Revision: 1611959

URL: http://svn.apache.org/r1611959
Log:
Bug 41319 - URLRewritingModifier : Allow Parameter value to be url encoded
Bugzilla Id: 41319

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/URLRewritingModifier.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/URLRewritingModifierGui.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml


Date: Sat Jul 19 20:35:59 2014
New Revision: 1611960

URL: http://svn.apache.org/r1611960
Log:
Bug 41319 - URLRewritingModifier : Allow Parameter value to be url encoded
Bugzilla Id: 41319

Modified:
    jmeter/trunk/docs/images/screenshots/url_rewriter.png
    jmeter/trunk/xdocs/images/screenshots/url_rewriter.png
    jmeter/trunk/xdocs/usermanual/component_reference.xml
Comment 2 Philippe Mouawad 2014-07-19 21:06:03 UTC 
Date: Sat Jul 19 21:04:59 2014
New Revision: 1611965

URL: http://svn.apache.org/r1611965
Log:
Bug 41319 - URLRewritingModifier : Allow Parameter value to be url encoded
Fix test error
Bugzilla Id: 41319

Modified:
Comment 3 The ASF infrastructure team 2022-09-24 20:37:38 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/1848