In my opinion, setenv.sh/setenv.bat seems a better candidate for CATALINA_BASE. And I'm canvassing for opinions that agree or disagree. In terms of rationale, I think those that understand the concept of having a separate CATALINA_BASE/CATALINA_HOME will see the obvious rationale there. setenv.sh/setenv.bat is the container of settings for a Tomcat instance, so you should be able to have different settings for different Tomcat instances deployed against one installed version of Tomcat. I will attach a patch that implements this.
Created attachment 20953 [details] *was* Patch to extend sourcing of setenv.sh/setenv.bat to CATALINA_BASE but this is wrong. Please look for tc5.5.x-setenv-taketwo-patch.diff Patch to extend sourcing of setenv.sh/setenv.bat to CATALINA_BASE
Created attachment 20954 [details] Correct patch to extend sourcing of setenv.sh/setenv.bat to CATALINA_BASE Correct patch to extend sourcing of setenv.sh/setenv.bat to CATALINA_BASE
I like it! Many thanks for the patch. I have applied it to trunk and proposed it for back port to 5.5.x and 6.0.x
Fixed in 5.5.x and will be included in 5.5.26 onwards.