Bug 48573 - LDAPExtSampler directory context handling
Summary: LDAPExtSampler directory context handling
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.3.4
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2010-01-19 07:56 UTC by Rainer Jung
Modified: 2010-01-20 15:52 UTC (History)
0 users


Attachments
Patch against trunk r900635 (14.54 KB, patch)
2010-01-19 07:56 UTC, Rainer Jung 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Jung 2010-01-19 07:56:23 UTC 
Created attachment 24860 [details]
Patch against trunk r900635

LdapExtSampler has two Hashtables: ldapContexts and ldapConnections. One should cache DirContext instances per thread, the other LDAPExtClient instances.

But inspection of the class LDAPExtClient shows, that all of it's method can be declared static. All data needed is always passed in as method arguments. So there's no need to use a Hashtable of instances. Also: the ldapConnections Hashtable wasn't filled correctly. So let's turn to static methods and remove the Hashtable.

It seems the ext ldap sampler was broken for more complex bind, search, unbind tests and at least those work with the patch applied.

Patch is against trunk, but the same situation occurs in 2.3.4.
Comment 1 Sebb 2010-01-20 15:52:21 UTC 
Good catch:

URL: http://svn.apache.org/viewvc?rev=901444&view=rev
Log:
Bug 48573 - LDAPExtSampler directory context handling
Comment 2 The ASF infrastructure team 2022-09-24 20:37:44 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2334