Created attachment 30184 [details] patch Because mice are awesome I find the current implementation awkward : - No visual clue of where the node will be dropped - a popup with "insert before" , etc.. - no automatic scrolling when draging a node - no automatic expanding this patch replace the drag and drop implementation with a TransferHandler You can only move 1 node but it's also broken in trunk tests were made on a Mac
Created attachment 30185 [details] example1
Created attachment 30186 [details] example2
Created attachment 30189 [details] Just made it standard patch Hello, My tests on Mac are fine. There is only one thing, you cannot drop an element as last child of a parent, Benoit W. reported this was a limitation: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6560955 http://stackoverflow.com/questions/4850988/drop-nodes-in-a-jtree-at-different-nesting-levels Using it I feel it improves usability particularly: - The visual indicator for drop position - The unfolding of non leaf nodes - The little time gain that comes from removed popup (insert before, after ,as child) So I vote for its integration.
Works fine on Windows 7
+1 for apply patch. Works on my Linux (Debian Wheezy with Gnome 3)
Created attachment 30192 [details] better version better naming of variables you can also move a node to its parent : the node is then moved as the last child
Created attachment 30194 [details] last version remove unused drag&drop code from mainframe
Note that my comment about multi-selection D&D in trunk is not correct : it is only partially broken : - it's difficult to use (see https://issues.apache.org/bugzilla/show_bug.cgi?id=51823) - elements order can be lost - parent-child relation can be lost Jmeter commiters / users : do you use multi-selection D&D in its current implementation ? I had a look at non discontiguous multi-selection D&D and... it can be tricky. btw Cut-Paste and Copy-Paste do not work as intended with non discontiguous multi-selection :-( I think that even without the ability to move more than one node, this patch improves usability (see comment 3) I plan to work on a restricted form of D&D for multi-selection but I don't know when. Benoit WIART
As for me, I was not aware it was possible and I must say I don't understand how multi-selection DnD works. So still +1 for me.
I comment 8 : replace non discontiguous by discontiguous ....
Date: Wed Apr 17 20:16:53 2013 New Revision: 1469057 URL: http://svn.apache.org/r1469057 Log: Bug 54834 - Improve Drag & Drop in the jmeter tree Bugzilla Id: 54834 Added: jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java (with props) Removed: jmeter/trunk/src/core/org/apache/jmeter/gui/action/DragNDrop.java Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeListener.java jmeter/trunk/xdocs/changes.xml Date: Wed Apr 17 20:17:48 2013 New Revision: 1469058 URL: http://svn.apache.org/r1469058 Log: Bug 54834 - Improve Drag & Drop in the jmeter tree FIX EOL Bugzilla Id: 54834 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java (props changed)
Thanks, applied
Date: Fri Jul 12 18:36:08 2013 New Revision: 1502645 URL: http://svn.apache.org/r1502645 Log: Bug 54834 - Improve Drag & Drop in the jmeter tree Select dropped nodes Bugzilla Id: 54834 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeTransferHandler.java
Date: Sat Jul 13 21:02:01 2013 New Revision: 1502878 URL: http://svn.apache.org/r1502878 Log: Bug 54834 - Improve Drag & Drop in the jmeter tree http://mail-archives.apache.org/mod_mbox/jmeter-dev/201307.mbox/%3CCAOGo0VZ0z3GMbfsq_gSB%2Bp7nTUqLng6Gy2ecvYbD8_AKb-Dt5w%40mail.gmail.com%3E Bugzilla Id: 54834 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/Move.java
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3096