Bug 55435 - ComboStringEditor could be simplified to make most settings final
Summary: ComboStringEditor could be simplified to make most settings final
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.9
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 17:55 UTC by Sebb
Modified: 2013-08-16 18:04 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2013-08-16 17:55:44 UTC 
The package-private ComboStringEditor can be reconfigured to change the tags, edit and undefined behaviour after creation. 

This makes the code more complicated than it needs to be. Currently JMeter does not change the settings after the class has been created, so it could be simplified by removing the setTags(), setNoEdit() and setNoUndefined() methods, replacing them with constructor parameters.
Comment 1 Sebb 2013-08-16 18:04:42 UTC 
URL: http://svn.apache.org/r1514823
Log:
ComboStringEditor could be simplified to make most settings final
Bugzilla Id: 55435

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/ComboStringEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/FileEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 The ASF infrastructure team 2022-09-24 20:37:54 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3195