Bug 58406 - IfController : Allow use of Nashorn Engine if available for JavaScript evaluation
Summary: IfController : Allow use of Nashorn Engine if available for JavaScript evalua...
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 19:58 UTC by Philippe Mouawad
Modified: 2015-10-17 13:49 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2015-09-13 19:58:57 UTC 
Since Java8, Nashorn engine provides Javascript language.

Benchmarks show the engine performs better than rhino (default used by JMeter):
- http://ariya.ofilabs.com/2014/03/nashorn-the-new-rhino-on-the-block.html

This enhancement will use as engine:
- Rhino if JAVA < 8
- Nashorn if JAVA >= 8


To keep backward compatibility, this enhancement will introduce this new property:
ifcontroller.use_rhino=false
Comment 1 Philippe Mouawad 2015-09-13 20:14:31 UTC 
Author: pmouawad
Date: Sun Sep 13 20:12:47 2015
New Revision: 1702817

URL: http://svn.apache.org/r1702817
Log:
Bug 58406 - IfController : Use Nashorn Engine if available for JavaScript evaluation
Bugzilla Id: 58406

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/control/IfController.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2015-10-03 20:26:17 UTC 
Property is renamed to:
javascript.use_rhino

It's default value will be true as of JMeter 2.14
Comment 3 Philippe Mouawad 2015-10-03 20:29:49 UTC 
Author: pmouawad
Date: Sat Oct  3 20:27:45 2015
New Revision: 1706622

URL: http://svn.apache.org/viewvc?rev=1706622&view=rev
Log:
Bug 58406 - IfController : Allow use of Nashorn Engine if available for JavaScript evaluation
Apply what has been discussed at:
- http://mail-archives.apache.org/mod_mbox/jmeter-dev/201509.mbox/%3C55F9CB45.9040203%40internetallee.de%3E

Rename property and make Rhino still the default.
Add a note.

Bugzilla Id: 58406

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/control/IfController.java
    jmeter/trunk/xdocs/changes.xml
Comment 4 Philippe Mouawad 2015-10-17 13:49:23 UTC 
Author: pmouawad
Date: Sat Oct 17 13:47:18 2015
New Revision: 1709167

URL: http://svn.apache.org/viewvc?rev=1709167&view=rev
Log:
Bug 58406 - IfController : Use Nashorn Engine if available for JavaScript evaluation
Apply same rules as for JavaScript function
Bugzilla Id: 58406

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/IfController.java


Author: pmouawad
Date: Sat Oct 17 13:47:57 2015
New Revision: 1709168

URL: http://svn.apache.org/viewvc?rev=1709168&view=rev
Log:
Bug 58406 - IfController : Use Nashorn Engine if available for JavaScript evaluation
Make getInstance private
Bugzilla Id: 58406

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/IfController.java
Comment 5 The ASF infrastructure team 2022-09-24 20:38:00 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3670