Bug 54973 - mod_proxy_fcgi does not honnor Timeout / ProxyTimeout
Summary: mod_proxy_fcgi does not honnor Timeout / ProxyTimeout
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_proxy_fcgi (show other bugs)
Version: 2.4.6
Hardware: All Linux
: P2 critical with 3 votes (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 06:47 UTC by bruno.canet
Modified: 2014-05-05 23:51 UTC (History)
2 users (show)



Attachments
proposed patch (2.47 KB, patch)
2013-09-13 07:50 UTC, jkaluza
Details | Diff
proposed patch v2 (2.58 KB, patch)
2013-09-13 08:04 UTC, jkaluza
Details | Diff
proposed patch v3 (854 bytes, patch)
2013-09-13 12:12 UTC, jkaluza
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bruno.canet 2013-05-15 06:47:07 UTC
mod_proxy_fcgi is configured to proxy request to php-fpm as follow:
ProxyPassMatch ^/(.*\.php)$ fcgi://127.0.0.1:9000/opt/httpd/htdocs/app/$1

If a php script takes more than 30 seconds to execute, a HTTP RC 500 is returned to the client.

php max_execution_time is set to 300 seconds 

I used the following script to validate that the error was not due to php max_execution_time issue.

<?php
    error_log("executing script... ");
    $time = time();
    for ($t = 0; $t <= 15; $t++) {
        error_log("Logging: $t (".(time()-$time)." seconds)");
        sleep(5);
    }
    error_log("execution done (".(time()-$time)." seconds)");
?>
after 30 seconds, the HTTP 500 is returned to the client, but in the php error_log the script continue its execution.

According to the documentation, TimeOut is set to 60 seconds by default, so it should not be an issue, but in case, the following explicit definition were tested without improvement:

1. ProxyPassMatch ^/(.*\.php)$ fcgi://127.0.0.1:9000/opt/httpd/htdocs/app/$1 timeout=300

2. in virtual host: ProxyTimeout 300

3 in server config: TimeOut 300

The only workaround found was to hardcode the timeout in the mod_proxy_fcgi.c:
--- ./modules/proxy/mod_proxy_fcgi.c.orig       2013-04-16 16:09:25.970332062 +0200
+++ ./modules/proxy/mod_proxy_fcgi.c    2013-04-16 16:09:56.311088966 +0200
@@ -575,7 +575,7 @@
         /* We need SOME kind of timeout here, or virtually anything will
          * cause timeout errors. */
         if (! conn->worker->s->timeout_set) {
-            timeout = apr_time_from_sec(30);
+            timeout = apr_time_from_sec(300);
         }

         rv = apr_poll(&pfd, 1, &n, timeout);
Comment 1 apacheorg 2013-09-11 13:23:59 UTC
we confirm this behavior with: 
mod_proxy_fcgi
mod_proxy
apache event mpm 
on latest stable apache 2.4.6 

we are using: 

(we tried both inside and outside virtualhost: )
<Proxy fcgi://socket=%2fdev%2fshm%2ffpm-php.sock>
		ProxySet timeout=3600
		ProxySet connectiontimeout=3600
</Proxy>

ProxyPassMatch ^/(.*\.php(/.*)?)$ fcgi://socket=%2fdev%2fshm%2ffpm-php.sock/mobilnet.sk/$1 timeout=3600 connectiontimeout=3600

OR
RewriteCond %{ENV:REDIRECT_STATUS} ^$
RewriteRule ^/?(.*\.php)$ fcgi://socket=\%2fdev\%2fshm\%2ffpm-php.sock/path/$1 [P,L]

but none of them accepts the timeout: 
[proxy_fcgi:error] (70007)The timeout specified has expired: [...] AH01075: Error dispatching request to:
Comment 2 jkaluza 2013-09-13 07:50:55 UTC
Created attachment 30828 [details]
proposed patch

This patch removes hardcoded 30 second timeout from mod_proxy_fcgi and replaces it with ProxyTimeout/Timeout.
Comment 3 jkaluza 2013-09-13 08:04:33 UTC
Created attachment 30829 [details]
proposed patch v2

Better patch respecting previous "conn->worker->s->timeout" timeout if set.
Comment 4 jkaluza 2013-09-13 12:07:25 UTC
The fact that you were not able to set "timeout=300" is caused by PR 43513.
Comment 5 jkaluza 2013-09-13 12:12:02 UTC
Created attachment 30833 [details]
proposed patch v3

Even better patch. Now uses apr_socket_timeout_get.
Comment 6 Jeff Trawick 2014-05-05 23:51:54 UTC
Fixed in 2.4.8:

 *) mod_proxy_fcgi: Use apr_socket_timeout_get instead of hard-coded
     30 seconds timeout. [Jan Kaluza]