Bug 1260

Summary:	missing docu for --create-prefs (mixed up with spamd's --nouser-config)
Product:	Spamassassin	Reporter:	Duncan Findlay <duncf>
Component:	spamassassin	Assignee:	Malte S. Stretz <spamassassin-bugger>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	dev, jay-spama
Priority:	P2	Keywords:	backport
Version:	SVN Trunk (Latest Devel Version)
Target Milestone:	2.52
Hardware:	All
OS:	All
URL:	http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=164284
Whiteboard:
Attachments:	suggested patch new suggested patch!

Description Duncan Findlay 2002-12-05 20:27:47 UTC

[ Hmm... this was probably my fault! ]

From: Francesco Potorti` <pot@gnu.org>
To: Debian Bug Tracking System <submit@bugs.debian.org> 
Subject: spamassassin: --nouser-config not implemented 
Date: Fri, 11 Oct 2002 12:31:22 +0200

Package: spamassassin
Version: 2.41-2
Severity: minor

While spamassassin accepts the -x option, it does not know about the
(equivalent) --nouser-config, documented in the usage output and the
manual. 

-- System Information
Debian Release: testing/unstable
Kernel Version: Linux pot.cnuce.cnr.it 2.4.18 #2 Mon Jul 29 12:21:48 CEST 2002
i686 unknown unknown GNU/Linux

Versions of the packages spamassassin depends on:
ii  debconf        1.0.32         Debian configuration management system
ii  libhtml-parser 3.25-1         A collection of modules that parse HTML text
ii  libnet-smtp-se 1.1-1          A native Perl SMTP Server implementation
ii  perl           5.6.1-7        Larry Wall's Practical Extraction and Report
ii  spamc          2.41-2         Client for perl-based spam filtering daemon
ii  sysvinit       2.84-3         System-V like init.

Comment 1 Justin Mason 2002-12-19 10:54:52 UTC

now fixed in CVS

Comment 2 Jay Levitt 2003-02-25 06:25:09 UTC

This fix did not make it into 2.50...

Comment 3 Malte S. Stretz 2003-02-25 06:35:28 UTC

It should have been in 2.44 already. I'll check it out.

Comment 4 Malte S. Stretz 2003-03-21 14:48:19 UTC

Huh? That's really weird. Seems like the --nouser-config got lost. 
 
This is passed to GetOptions(): 
  'create-prefs!'                     => \$opt{'create-prefs'}, 
  'x'                                 => sub { $opt{'create-prefs'} = 0 }, 
 
The docu still says 
  -x, --nouser-config               Disable user config files 
the create-prefs is completely unknown. 
 
I'll try to find the commit which did this...

Comment 5 Malte S. Stretz 2003-03-21 15:03:07 UTC

I'm slightly confused. Seems like spamassassin never knew the nouser-config 
option; I think it is a spamd option. Something is really weird in there: Just 
compare the docu for -x and the GetOpts() -x... Justin, I can't find the 
commit you mentioned but maybe I'm blind.

Comment 6 Justin Mason 2003-03-21 17:08:48 UTC

bugger -- the commit in question must have failed and I didn't notice!
either that or it got overwritten by another commit and badly merged.
wierd.  Anyway, I think the patch will need to be applied again...

Comment 7 Malte S. Stretz 2003-03-24 13:16:20 UTC

applied both to HEAD and STABLE

Comment 8 Malte S. Stretz 2003-03-24 13:34:38 UTC

not yet ;-)

Comment 9 Malte S. Stretz 2003-03-24 13:40:51 UTC

the real problem is that somebody mixed up the spamassassin -x option with the 
one from spamd. all what has to be done here is a correct docu for 
--create-prefs instead of --nouser-config

Comment 10 Theo Van Dinter 2003-03-24 13:53:42 UTC

Created attachment 804 [details]
suggested patch

Comment 11 Theo Van Dinter 2003-03-24 14:00:03 UTC

Created attachment 805 [details]
new suggested patch!

Comment 12 Malte S. Stretz 2003-03-24 14:11:11 UTC

OKAY: looks good ;-)

Comment 13 Malte S. Stretz 2003-03-24 14:22:32 UTC

applied both to HEAD and STABLE.