Bug 1527

Summary:	new MIME decoder
Product:	Spamassassin	Reporter:	Daniel Quinlan <quinlan>
Component:	Libraries	Assignee:	Theo Van Dinter <felicity>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dev, nj, skanthak-sabug, spamassassinbugzilla
Priority:	P2
Version:	SVN Trunk (Latest Devel Version)
Target Milestone:	2.70
Hardware:	Other
OS:	other
Whiteboard:
Bug Depends on:
Bug Blocks:	2025, 2101, 2106, 2213, 2290, 2319, 2367, 2375, 2402, 2453, 2500, 2622, 2739

Description Daniel Quinlan 2003-02-22 18:27:52 UTC

Write a new MIME decoder and integrate it with the existing MIME and
MIME attachment tests in EvalTests.pm.  My reasoning: I think it makes
sense for us to have our own decoder (like HTML) because we'll be able to
integrate the parsing/decoding with tests (like HTML), to avoid extra passes
over the message, and to avoid extra external dependencies.  Writing our own
decoder will also allow us to be more efficient (and correct!) about when
to decode HTML in the body.

Comment 1 Duncan Findlay 2003-02-22 18:37:35 UTC

Subject: Re: [SAdev]  New: new MIME decoder

Wasn't a new MIME decoder one of the main features of SA 3? Maybe we
should investigate how much work SA 3 would be to get to the level
we're at now.

Comment 2 Daniel Quinlan 2003-02-22 19:08:33 UTC

> Wasn't a new MIME decoder one of the main features of SA 3? Maybe we
> should investigate how much work SA 3 would be to get to the level
> we're at now.

Maybe.  I don't currently believe that we should drop our current
code base to switch to a new one.  Rewriting specific portions of the
code base has worked pretty darn well for us.  Some examples: the HTML parser
that replaced the original HTML substitution code, the new ArchiveIterator,
and the updated locking code.

There are some nice features in the SA3 decoder although it's missing
some stuff I want, I might be able to add it easier than writing one from
scratch.  I'll take a look at SA3 and the SA3 decoder, thanks for the
idea.

Comment 3 Justin Mason 2003-03-18 15:52:17 UTC

BTW, I think SA3 is quite a good idea.  it should not be too hard to port our
current codebase over to that framework, and it's certainly cleaner than what we
have now.

Comment 4 Daniel Quinlan 2003-05-18 21:40:32 UTC

moving a bunch of bugs to 2.70 milestone

Comment 5 Theo Van Dinter 2003-09-23 17:21:06 UTC

a quick moo-haha, and the bug is mine. :)

Comment 6 Theo Van Dinter 2004-01-11 20:05:30 UTC

just an update ...

this is mostly in place: when a NoMailAudit object is created, the new parser generates a parse 
object with the appropriate data.

nothing has been converted to use the new parse object yet though.  fyi.

Comment 7 Theo Van Dinter 2004-01-23 21:13:33 UTC

more updates ...

I've merged in the new MIME parser with the text generation in PerMsgStatus.  there's still some 
pieces that need work, but PerMsgStatus is a heck of a lot smaller, and the MIME parsing/decoding 
is all correct now. :)

Comment 8 Theo Van Dinter 2004-01-24 11:13:47 UTC

*** Bug 2914 has been marked as a duplicate of this bug. ***

Comment 9 Theo Van Dinter 2004-01-24 11:16:00 UTC

*** Bug 2628 has been marked as a duplicate of this bug. ***

Comment 10 Theo Van Dinter 2004-01-24 21:37:56 UTC

ok, I'm going to call this officially closed now.  the new mime parser is integrated with 2.70, and all 
of the related bugs were fixed. :)

Comment 11 Theo Van Dinter 2004-03-06 17:46:40 UTC

*** Bug 3045 has been marked as a duplicate of this bug. ***