Bug 2434

Summary: Makefile.PL might warn with a "WARNING: NO_META is not a known parameter"
Product: Spamassassin Reporter: Malte S. Stretz <spamassassin-bugger>
Component: Building & PackagingAssignee: Malte S. Stretz <spamassassin-bugger>
Status: RESOLVED FIXED    
Severity: trivial CC: dev
Priority: P3    
Version: 2.60   
Target Milestone: 2.60   
Hardware: All   
OS: All   
Whiteboard:
Attachments: patch against Makefile.PL

Description Malte S. Stretz 2003-09-11 13:28:52 UTC
Nothing to worry about. That's because the creation of META.yml was introduced 
some time after 6.00 but the parameter to suppress the creation of that file 
(or to keep EU::MM from adding it to the MANIFEST, I dont know exactly) is 
added for all versions later that 6.00. I'll ask Michael Schwern for the exact 
version and will "fix" that for the final release.
Comment 1 Malte S. Stretz 2003-09-11 13:31:35 UTC
assigning to me -- you can already +1 it, it will be a one-character fix in 
line 224 of Makefile.PL :) 
Comment 2 Malte S. Stretz 2003-09-11 13:54:40 UTC
Created attachment 1348 [details]
patch against Makefile.PL

here it is
Comment 3 Daniel Quinlan 2003-09-11 14:00:16 UTC
+1 okay
Comment 4 Theo Van Dinter 2003-09-11 17:07:51 UTC
+1 looks good. :)
Comment 5 Malte S. Stretz 2003-09-11 17:10:35 UTC
committed 
Comment 6 Malte S. Stretz 2003-09-12 11:58:58 UTC
in bug 2388 Theo said: 
> the NO_META stuff still occurs with rc4.  which should have the patch 
> installed. 
 
RC4 has this patch. which version of EU::MM did you try that with? 
Comment 7 Theo Van Dinter 2003-09-12 12:06:48 UTC
Subject: Re: [SAdev]  Makefile.PL might warn with a "WARNING: NO_META is not a known parameter"

On Fri, Sep 12, 2003 at 12:06:18PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> RC4 has this patch. which version of EU::MM did you try that with? 

I got this with both 6.03 and 6.05.

Comment 8 Theo Van Dinter 2003-09-12 16:00:28 UTC
never mind.  this was my bad.