Bug 7967

Summary:	Spam Filters No Longer Work Discarding Many Ham Emails
Product:	Spamassassin	Reporter:	Dennis German <DGermanbz>
Component:	sa-update	Assignee:	SpamAssassin Developer Mailing List <dev>
Status:	RESOLVED DUPLICATE
Severity:	major	CC:	apache, billcole
Priority:	P3
Version:	SVN Trunk (Latest Devel Version)
Target Milestone:	4.0.0
Hardware:	All
OS:	All
Whiteboard:

Description Dennis German 2022-04-04 12:32:42 UTC

Since expired grace period, implementing "welcomelist" and "blocklist" wording any existing user_prefs will cause spamassassin to not reduce the score of welcomelist senders sufficiently to over ride otherwise spammy emails. This results in emails expected to be received to be treated as spam.
If the action in filters is to discard spam emails from senders explicitly set to be accepted are discarded.

Part of the updgrade process MUST include revising ALL user_prefs to use new keywords. The implementation MUST NOT remove comments from entries in these lists and MUST not sort the list.

This MUST be implemented in sa-update for systems which have already upgraded to correct outdated user_prefs.

Comment 1 Bill Cole 2022-04-04 15:30:04 UTC

The terminology change is a work in progress and is NOT yet fully implemented. The partial change for v3.4.x includes ONLY rule names, not configuration parameter name changes. The work in the Subversion "trunk" towards v4.0.0 is ongoing and should only be used in testing circumstances. That work is tracked in bug #7826. Using the new terminology for configuration parameters with v3.x is not supported and cannot be supported.

It is not clear what you mean by "expired grace period" as there is no such thing in SpamAssassin. As such, it's not entirely clear what sort of problem you are talking about. A concrete test case would help a great deal. 

Conversion of local config files is as of yet an unsettled issue for v4.0.0. It will NOT be done in sa-update, as that is a tool solely for maintenance of rules "channels" and performs no changes of locally-modified files. Because the location of user prefs can vary significantly based on distribution packaging and local configuration choices, it is possible that when backward compatibility is actually dropped (no sooner than v4.1) the changes to user prefs will need to be done manually. Packagers of SA for various distros may choose to include tools of their own making for conversion of local and per-user config files.

Comment 2 Henrik Krohns 2022-04-16 06:31:50 UTC

Closing in favor of the main Bug 7826.

*** This bug has been marked as a duplicate of bug 7826 ***