Bug 1060 - SA reporting to DCC cosmetically ugly in 2.42
Summary: SA reporting to DCC cosmetically ugly in 2.42
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 2.41CVS
Hardware: Other Linux
: P2 normal
Target Milestone: ---
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-06 06:27 UTC by nix
Modified: 2002-10-09 20:39 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nix 2002-10-06 06:27:57 UTC 
In 2.42 (with Perl 5.8.0), reporting a sample spam yields the entire spam, on
stdout.

-D reveals that SpamAssassin is no longer discarding the stdout of `dccproc',
but is letting it filter through to its own stdout. Reporting thus becomes
rather noisy.

This kludge patch works for me (it's so small I'm not bothering to attach it):

Index: spamassassin/lib/Mail/SpamAssassin/Reporter.pm
===================================================================
RCS file: /cvsroot/spamassassin/spamassassin/lib/Mail/SpamAssassin/Reporter.pm,v
retrieving revision 1.32.2.3
diff -u -r1.32.2.3 Reporter.pm
--- spamassassin/lib/Mail/SpamAssassin/Reporter.pm      27 Sep 2002 20:41:02
-0000      1.32.2.3
+++ spamassassin/lib/Mail/SpamAssassin/Reporter.pm      6 Oct 2002 13:26:27 -0000
@@ -274,7 +274,7 @@
     alarm $timeout;
 
     my $cmd = join(" ", $self->{main}->{conf}->{dcc_path},'-t
many',$self->{main}->{conf}->{dcc_options});
-    open(DCC, "| $cmd") || die "Couldn't fork \"$cmd\"";
+    open(DCC, "| $cmd > /dev/null") || die "Couldn't fork \"$cmd\"";
     print DCC $fulltext;
     close(DCC) || die "Received error code $? from \"$cmd\"";
Comment 1 Justin Mason 2002-10-10 04:39:03 UTC 
applied