Bug 1381 - Rename NO_MX_FOR_FROM
Summary: Rename NO_MX_FOR_FROM
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P2 enhancement
Target Milestone: 2.50
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-14 14:52 UTC by Theo Van Dinter
Modified: 2003-02-15 09:49 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Van Dinter 2003-01-14 14:52:02 UTC 
NO_MX_FOR_FROM actually tries to do the MX->A fallback if MX doesn't exist, so
the name isn't 100% correct.  We should either rename it to something like
NO_MAILHOST_FOR_FROM, or perhaps add a NO_A_FOR_FROM and make this into a meta?
 (I have a feeling that would heavily FP though (kluge.net for instance), so
let's just rename it...)
Comment 1 Daniel Quinlan 2003-01-14 17:05:00 UTC 
> NO_MX_FOR_FROM actually tries to do the MX->A fallback if MX doesn't exist, so
> the name isn't 100% correct.  We should either rename it to something like
> NO_MAILHOST_FOR_FROM, or perhaps add a NO_A_FOR_FROM and make this into a meta?
> (I have a feeling that would heavily FP though (kluge.net for instance), so
> let's just rename it...)

You need both A and MX for the rule to work decently.  Renaming it would
be fine.  I suggest NO_DNS_FOR_FROM.
Comment 2 Theo Van Dinter 2003-02-13 11:53:04 UTC 
we could do this easily for 2.50.  just wait for the new scores to generate. :)
Comment 3 Theo Van Dinter 2003-02-15 18:49:58 UTC 
Ok, I renamed the rule, so marking as fixed. :)