Bug 147 - Improvments for dealing with BASE hrefs
Summary: Improvments for dealing with BASE hrefs
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 2.30CVS
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-27 19:00 UTC by Matthew Cline
Modified: 2002-06-15 03:58 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Some improvements to handling BASE hrefs patch None Matthew Cline [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Cline 2002-03-27 19:00:14 UTC 
I've made several improvements to the code for pre-pending the BASE hrefs
to non-absolute URIs:

- Standards compliant HTML renderers ignore BASE hrefs which aren't absolute,
  or which have non-standard protocols; this has been dealt with.

- A base href can have a filename in it.  For example, it could be
  "http://foo.com/index.html"; it now attempts to strip of trailing filenames
  from base hrefs.

- SA extracts URIs which aren't in an HTML tag and which have no
  protocol, like "www.foo.com/hello_world.html".  Rather than
  pre-pend the base href to these URIs, they should simply be
  pre-pended with the appriate protocol.
Comment 1 Matthew Cline 2002-03-27 19:00:52 UTC 
Created attachment 24 [details]
Some improvements to handling BASE hrefs
Comment 2 Matthew Cline 2002-04-02 22:09:52 UTC 
Checked into CVS.