Bug 1492 - $/ gets undef via Reporter
Summary: $/ gets undef via Reporter
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P1 blocker
Target Milestone: 2.50
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-17 01:52 UTC by Theo Van Dinter
Modified: 2003-02-17 00:48 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Van Dinter 2003-02-17 01:52:39 UTC 
I can't quite figure out where yet, but $/ is getting undefined
somewhere in Reporter.  Supposedly, Razor resets this, but Reporter is
calling enter_helper_run_mode and leave_helper_run_mode which should
reset $/ after the run.
Comment 1 Theo Van Dinter 2003-02-17 02:02:06 UTC 
It looks like our call to
Mail::SpamAssassin::PerMsgStatus::leave_helper_run_mode() is doing it.
A quick check shows that the keys in $self disappear when running Razor, so $/ gets set to undef as expected.
My assumption is $self changes somehow, but I have no idea how that would happen.  Another theory is that somewhere there's a undef $self or $self = {} or something.

We need to get this solved before a release since there are potentially third party apps which will have problems with this (such as my handlespam script... ;))
Comment 2 Theo Van Dinter 2003-02-17 02:28:12 UTC 
Subject: Re: [SAdev]  $/ gets undef via Reporter

On Mon, Feb 17, 2003 at 02:02:06AM -0800, bugzilla-daemon@hughes-family.org wrote:
> My assumption is $self changes somehow, but I have no idea how that would happen.  Another theory is that somewhere there's a undef $self or $self = {} or something.

Ok, if we call Mail::SpamAssassin::PerMsgStatus::*_run_mode() directly,
the problem exists.  If we call a $self->*_run_mode() stub instead,
it works, from what I can tell.

I'm sure there's a good reason for this, but I'm not seeing it right now.
Comment 3 Justin Mason 2003-02-17 08:21:00 UTC 
so -- fixed?
Comment 4 Theo Van Dinter 2003-02-17 09:12:55 UTC 
Subject: Re:  $/ gets undef via Reporter

On Mon, Feb 17, 2003 at 08:21:00AM -0800, bugzilla-daemon@hughes-family.org wrote:
> so -- fixed?

Maybe.  I did it at 5-something AM, wasn't quite thinking straight (just
woke up, still not...)  In my quick test it was fixed, but let me poke
at a few more things and I'll get back to you.
Comment 5 Theo Van Dinter 2003-02-17 09:48:51 UTC 
Ok, after some additional testing, I'm relatively confident I can call this fixed. :)  I'm still not quite sure why calling it from a stub is different, but I'll worry about that later.