Bug 1651 - Bayes::scan() doesn't untie_db properly
Summary: Bayes::scan() doesn't untie_db properly
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 2.50
Hardware: Other other
: P3 normal
Target Milestone: 2.50
Assignee: Malte S. Stretz
URL:
Whiteboard:
Keywords: backport
Depends on:
Blocks:
 
Reported: 2003-03-16 11:34 UTC by Theo Van Dinter
Modified: 2003-03-17 02:08 UTC (History)
1 user (show)



Attachment Type Modified Status Actions Submitter/CLA Status
proposed fix patch None Theo Van Dinter [HasCLA]
new version, checks to see if we're tied already patch None Theo Van Dinter [HasCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Van Dinter 2003-03-16 11:34:41 UTC
scan() will untie the bayes db if the scan succeeds properly, but if there's an error (no tokens, low prob, etc) the code jumps to "skip" which doesn't untie.

fix committed to 2.60, attaching patch for 2.50 shortly.
Comment 1 Theo Van Dinter 2003-03-16 11:37:38 UTC
Created attachment 761 [details]
proposed fix
Comment 2 Theo Van Dinter 2003-03-16 12:10:23 UTC
reassigning to malte. :)
Comment 3 Theo Van Dinter 2003-03-16 12:11:13 UTC
Created attachment 762 [details]
new version, checks to see if we're tied already
Comment 4 Malte S. Stretz 2003-03-16 14:18:00 UTC
OKAY: looks trivial 
Comment 5 Theo Van Dinter 2003-03-17 11:08:16 UTC
committed to 2.5x branch, closing bug. :)