Bug 1696 - You can forget messages you haven't learned
Summary: You can forget messages you haven't learned
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Learner (show other bugs)
Version: 2.52
Hardware: Other other
: P3 normal
Target Milestone: 2.53
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords: backport
Depends on:
Blocks:
 
Reported: 2003-03-27 12:18 UTC by Theo Van Dinter
Modified: 2003-03-27 10:26 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
suggested patch patch None Theo Van Dinter [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Van Dinter 2003-03-27 12:18:30 UTC 
I decided to forget a message that I did learn, and the counts went down as
expected.  But if I forget the message again, the counts went down again.  If I
change the Message-Id to a message I've never seen before, the counts still go down.

So, we need to check bayes_seen() before we forget.
Comment 1 Theo Van Dinter 2003-03-27 12:29:20 UTC 
Created attachment 822 [details]
suggested patch
Comment 2 Theo Van Dinter 2003-03-27 12:30:32 UTC 
the problem is that we check if the message is already learned, but the code
only checked if the seen database returned a value.  oops.

the patch puts the "not learned" check in the right place and adds a "seen value
invalid" check too.
Comment 3 Justin Mason 2003-03-27 17:10:31 UTC 
OKAY: looks good
Comment 4 Theo Van Dinter 2003-03-27 19:26:27 UTC 
applied to 2.53 and head.