Bug 1740 - check_rbl does not clean up the list of IPs
Summary: check_rbl does not clean up the list of IPs
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 2.52
Hardware: All All
: P3 normal
Target Milestone: 2.60
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords: dns
Depends on: 1455
Blocks:
  Show dependency tree
 
Reported: 2003-04-04 10:11 UTC by Eugene Pivovarov
Modified: 2003-04-05 06:02 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Pivovarov 2003-04-04 10:11:03 UTC 
There appears to be a bug in Mail::SpamAssassin::EvalTests::check_rbl. Here 
@ips is not verified before do_rbl_lookup calls, so it may contain duplicates, 
empty (undefined) or corrupted entries (such as "[127.0.0.1"). For example, 
duplicates are causing dnsbl.njabl.org to time out already during the first 
call of do_rbl_eval_tests in PerMsgStatus.pm.

Also, it would be nice if there was a configuration parameter (say, 
num_rbl_skip) which would allow to skip the first num_rbl_skip entries in @ips. 
Our ISP initially passes all incoming mail through a server running an 
antivirus, so the first three entries in @ips are always (ip-antivirus, 
localhost, ip-antivirus).
Comment 1 Justin Mason 2003-04-05 15:02:57 UTC 
OK, corruption fixed, dups fixed, and 'trusted_networks' param added for the 2nd
half.  These are in CVS HEAD and will be in 2.60.