Bug 1780 - bogus warning?
Summary: bogus warning?
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 2.53
Hardware: Other Solaris
: P5 normal
Target Milestone: 2.60
Assignee: Theo Van Dinter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-14 05:41 UTC by Marvin Solomon
Modified: 2003-06-12 07:39 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marvin Solomon 2003-04-14 05:41:29 UTC 
When invoked as spamassassin -x, it generates a message
on stderr: Failed to create default user preference file ...
I'm not sure whether this is a bug or a feature, but it took
me quite a while to track down why the setup as recommended
in http://advosys.ca/papers/postfix-filtering.html was "broken".
The problem is that sub create_default_prefs contains the code
   if ($self->{dont_copy_prefs}) { return(0); }
and sub init says
   if (!-f $fname && !$self->create_default_prefs($fname)) { warn ... }

I'm not sure whether the problem is bad advice from advosys or
a bug in spamassassin.
Comment 1 Theo Van Dinter 2003-06-12 15:38:00 UTC 
the way the code is written, calling the function and having it not create the
prefs is a failure.  so the return code is right, but we shouldn't call the
function if we shouldn't create the prefs.
Comment 2 Theo Van Dinter 2003-06-12 15:39:10 UTC 
ok, fix committed to 2.60. :)  thanks.