Bug 1905 - mkdir has too few arguments
Summary: mkdir has too few arguments
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: 2.54
Hardware: Other other
: P5 normal
Target Milestone: 2.55
Assignee: Theo Van Dinter
URL:
Whiteboard:
Keywords: backport
Depends on:
Blocks:
 
Reported: 2003-05-12 16:24 UTC by Kevin A. McGrail
Modified: 2003-05-18 09:18 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
suggested patch, adds a 0700 parameter patch None Theo Van Dinter [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2003-05-12 16:24:42 UTC 
Under Perl 5.005.03, the new mkdir routine in spamd bombs.  I mentioned this in 
Bug 1904 but it should get it's own bug.

I believe it's a very very simple fix.

diff -u Mail-SpamAssassin-2.54-Fix/spamd/spamd.raw Mail-SpamAssassin-
2.54/spamd/spamd.raw
--- Mail-SpamAssassin-2.54-Fix/spamd/spamd.raw  Mon May 12 19:22:02 2003
+++ Mail-SpamAssassin-2.54/spamd/spamd.raw      Mon May 12 15:15:36 2003
@@ -872,7 +872,7 @@
     my $spam_conf_dir = $dir . '/.spamassassin';  #needed for AWL, Bayes, etc.
     if ( ! -d $spam_conf_dir )
     {
-       if ( mkdir($spam_conf_dir,0700) )
+       if ( mkdir $spam_conf_dir )
        {
           logmsg "info: created $spam_conf_dir for $username.";
        }
Comment 1 Theo Van Dinter 2003-05-18 13:26:46 UTC 
Created attachment 967 [details]
suggested patch, adds a 0700 parameter
Comment 2 Theo Van Dinter 2003-05-18 13:27:33 UTC 
giving it to myself ...
Comment 3 Daniel Quinlan 2003-05-18 14:00:21 UTC 
OKAY: I suppose that's okay.

(770 would be fine for me since I'm using user-groups and a umask of 0002)
Comment 4 Theo Van Dinter 2003-05-18 14:02:11 UTC 
Subject: Re: [SAdev]  mkdir has too few arguments

On Sun, May 18, 2003 at 02:00:21PM -0700, bugzilla-daemon@hughes-family.org wrote:
> (770 would be fine for me since I'm using user-groups and a umask of 0002)

I was going to use 777 since that's the default for 5.6.x, but the rest
of our mkdir calls in spamd is 700, so ... :|
Comment 5 Duncan Findlay 2003-05-18 16:58:59 UTC 
OKAY
Comment 6 Theo Van Dinter 2003-05-18 17:18:55 UTC 
applied to stable and head