Subject: Re: [SAdev]  New: score REPLY_TO_EMPTY seems too high

REPLY_TO_EMPTY only matches when Reply-To is set, but not set to anything.
What mailer are you using? I severely doubt you set Reply-To to empty.

...that's what I would think, but REPLY_TO_EMPTY seems to be set even if 
there's no Reply-To header... here's the log for your email

168(new): ------------------------------ new run at Sun Apr  7 18:47:33 2002
172(new):    From: bugzilla-daemon@hughes-family.org
173(new):      To: bowen@dwelle.org
174(new): Subject: [Bug 193] score REPLY_TO_EMPTY seems too high
65(): running SpamAssassin check...
74(): SpamAssassin hit list: NO_REAL_NAME,REPLY_TO_EMPTY
75(): SpamAssassin hits: 3.9
76(): SpamAssassin required hits: 5
95(): looks OK, accepting to INBOX
295(accept): accepting to /var/mail/bowen
343(accept): Exiting with status DELIVERED = 0

And the raw mail (note no Reply-To header):

From bowen@dwelle.org Sun Apr  7 18:47:32 2002
Received: from shell.tsoft.com (root@shell.tsoft.com [198.144.192.5])
        by shell.rawbw.com (8.11.6/8.11.6) with ESMTP id g381lVH55415
        for <bowen@shell.rawbw.com>; Sun, 7 Apr 2002 18:47:32 -0700 (PDT)
Received: from mail.san.yahoo.com (mail.san.yahoo.com [209.132.1.30])
        by shell.tsoft.com (8.8.7/8.8.7) with ESMTP id SAA20833
        for <bowen@tsoft.com>; Sun, 7 Apr 2002 18:47:31 -0700 (PDT)
Delivered-To: bowen@dwelle.org
Received: from smtp10.atl.mindspring.net (207.69.200.246) by mail.san.yahoo.com 
(6.5.017.1)
        id 3CA368D1002923C7 for bowen@dwelle.org; Sun, 7 Apr 2002 18:47:27 -0700
Received: from user-vcaumuk.dsl.mindspring.com ([216.175.91.212] 
helo=belphegore.hughes-family.org)
        by smtp10.atl.mindspring.net with esmtp (Exim 3.33 #1)
        id 16uOFg-0005iZ-00
        for bowen@dwelle.org; Sun, 07 Apr 2002 21:47:24 -0400
Received: by belphegore.hughes-family.org (Postfix, from userid 76)
        id 5D2647D885; Sun,  7 Apr 2002 18:47:23 -0700 (PDT)
From: bugzilla-daemon@hughes-family.org
To: bowen@dwelle.org
Subject: [Bug 193] score REPLY_TO_EMPTY seems too high
X-Bugzilla-Reason: Reporter
Message-Id: <20020408014723.5D2647D885@belphegore.hughes-family.org>
Date: Sun,  7 Apr 2002 18:47:23 -0700 (PDT)
Status: O
X-Status: 
X-Keywords:                  
X-UID: 2129

http://www.hughes-family.org/bugzilla/show_bug.cgi?id=193

...and the .cf entries:

shell:~/.spamassassin grep  REPLY_TO_EMPTY *
20_head_tests.cf:header REPLY_TO_EMPTY          Reply-To =~ /^(?:\@|\s*$)/ [if-
unset: UNSET]
20_head_tests.cf:describe REPLY_TO_EMPTY                Reply-To: is empty
30_text_es.cf:lang es describe REPLY_TO_EMPTY           Reply-To: está vacío
30_text_pl.cf:lang pl describe REPLY_TO_EMPTY           Odpowiedz-Do: jest 
puste (Reply-To)
50_scores.cf:#score REPLY_TO_EMPTY                 4.256
50_scores.cf:score REPLY_TO_EMPTY                 3.256
shell:~/.spamassassin 

I did a little more debugging, and it's this test that's failing.. even if 
@hdrs comes back empty, $#hdrs is still 0, and so $_ isn't set to undef, and so 
it isn't subsequently set to $defval. 
  if ($#hdrs >= 0) {... 
this is probably a problem with @hdrs = $self->{msg}->get_header, but for now I 
just did this: 
  if ($#hdrs >= 0 and "@hdrs" ne '' ) {...

which seems to have fixed it.. -- so it's not that the score for REPLY_TO_EMPTY 
is too high, it's that the code is producing false positives...

well, that didn't work after all. as I suspected, it's really a problem with 
  $self->{msg}->get_header
if I use this instead
  $self->{msg}->{mail_object}->head->get ($hdrname);

then the tests work as designed, i.e. $#hdrs == -1 if there is no Reply-To 
header at all, and $#hdrs == 0 if there is a Reply-To header, but it's empty. 

Looks like this has turned into a dupe of 192


*** This bug has been marked as a duplicate of 192 ***