Bug 205 - URI_IS_POUND fixes
Summary: URI_IS_POUND fixes
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 2.30CVS
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: Craig Hughes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-10 17:59 UTC by Matthew Cline
Modified: 2002-06-15 03:58 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
URI_IS_POUND fixes patch None Matthew Cline [HasCLA]
Modified patch to catch more instances patch None Craig Hughes [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Cline 2002-04-10 17:59:10 UTC 
Boy, this'll learn me to make test cases for stuff I add.

Two problems:

- The URI_IS_POUND pattern didn't take into account the prepending of
  the base URL or "http://"; it should test for "/\#$" (a slash followe
  by a pound at the very end of an URI), rather than "^\#$" (a pound all
  by itself, which will never happen because of the prepending).

- URI extraction regexps that do_body_uri_tests() of PerMsgStatus.pm uses
  needed to have the "#" symbol added to the list of reserved characters
  for things like "http://#" to be picked up by the URI tests.
Comment 1 Matthew Cline 2002-04-10 17:59:47 UTC 
Created attachment 64 [details]
URI_IS_POUND fixes
Comment 2 Craig Hughes 2002-04-10 23:54:33 UTC 
Created attachment 65 [details]
Modified patch to catch more instances
Comment 3 Craig Hughes 2002-04-11 00:06:18 UTC 
Commited my modified patch to CVS.  I was going to add some tests too, but there are problems putting #'s in test strings, because the rule parser thinks they're comments.  And I'm too tired to reliably change the rule parser right now, days before a release.