Bug 2246 - dubious use of 'Server' handle in restart_handler()
Summary: dubious use of 'Server' handle in restart_handler()
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P2 major
Target Milestone: 2.60
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 2225
  Show dependency tree
 
Reported: 2003-07-19 17:27 UTC by Malte S. Stretz
Modified: 2003-07-21 22:32 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
patch against spamd.raw patch None Malte S. Stretz [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2003-07-19 17:27:18 UTC 
ok, I grepped our sources, grepped the whole Perl lib but nowhere could I find 
a handle 'Server' as it's used in restart_handler(). Except in an example in 
perlipc ;-) 
 
    if (!eof Server) { 
      shutdown (Server, 2); 
      close Server; 
Justin, you committed that lines in rev. 1.184 -- what does it do? Or what 
*should* it do? :o) I think it might be the reason for bug 2225.
Comment 1 Malte S. Stretz 2003-07-20 12:25:19 UTC 
Created attachment 1174 [details]
patch against spamd.raw

I guess that code is really nonsense, as with this patch HUPing spamd under
Perl 5.005 works. Please review.
Comment 2 Theo Van Dinter 2003-07-20 15:35:40 UTC 
+1
Comment 3 Justin Mason 2003-07-21 14:11:43 UTC 
+1.  Server must have been left over from when that's what it was called, oops.
 code rot...
Comment 4 Malte S. Stretz 2003-07-22 06:32:06 UTC 
committed. seems like this didn't fix 2225 though :-(