Bug 2303 - backwards compat broken for user-added RBL tests
Summary: backwards compat broken for user-added RBL tests
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 2.60
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-09 13:29 UTC by Justin Mason
Modified: 2003-08-11 20:21 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2003-08-09 13:29:47 UTC 
I've mentioned this on sa-devel, but not as a bug AFAIK.
Basically in 2.[45]x, it's OK to use 

  header FOO eval:check_rbl('blah')

but in 2.60 the code requires use of rbleval: otherwise the RBL is
not queried, and no warning is printed.

Many third-party sites suggest using this, for example
http://improbable.org/chris/index.php?ID=109 -- so we should at least
add backwards compat (it's very inexpensive).

Patch to follow.  This patch adds support for eval:check_rbl*() -- but issues a
debug message about it being deprecated, if it's found.  (thoughts -- should
this be a real warning message?)
Comment 1 Justin Mason 2003-08-09 13:30:14 UTC 
Created attachment 1220 [details]
fix
Comment 2 Justin Mason 2003-08-09 13:30:58 UTC 
moving to 2.60; releasing without this would break backwards compat for this
feature in a nasty way.
Comment 3 Theo Van Dinter 2003-08-10 13:53:16 UTC 
+1 I think the patch looks fine.
Comment 4 Theo Van Dinter 2003-08-12 04:21:02 UTC 
committed.