Bug 2337 - most OSIRU tests not running when set1 used
Summary: most OSIRU tests not running when set1 used
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Score Generation (show other bugs)
Version: 2.60
Hardware: Other other
: P5 major
Target Milestone: 2.60
Assignee: Daniel Quinlan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-21 21:52 UTC by Daniel Quinlan
Modified: 2003-08-22 03:51 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
proposed fix patch None Daniel Quinlan [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Quinlan 2003-08-21 21:52:12 UTC 
RCVD_IN_OSIRU has a score of 0 in set1 so none of the RCVD_IN_OSIRU sub-tests
run (except for the RCVD_IN_OSIRU_DIALUP because it's launched differently).

This was not an issue with the mass-check for set3 because the score was 0.001
at that time.

Moral of the story: don't reduce the scores of low-scoring top-level network
tests to 0 unless all sub-tests are also 0.
Comment 1 Daniel Quinlan 2003-08-21 21:56:34 UTC 
Created attachment 1252 [details]
proposed fix

This patch also changes the documentation to refer to each sub-test as a
"sub-test" rather than a "sub-rule" since "sub-rule" is used with a different
meaning elsewhere in Conf.pm.
Comment 2 Daniel Quinlan 2003-08-21 21:56:50 UTC 
moving to 2.60
Comment 3 Daniel Quinlan 2003-08-21 23:22:03 UTC 
reassigning
Comment 4 Theo Van Dinter 2003-08-22 07:14:26 UTC 
+1

oops.  I checked for meta dependencies with 0 score, but didn't think about the 
network sub tests.  doh!  have to add that as a release check.
Comment 5 Justin Mason 2003-08-22 11:42:38 UTC 
+1
Comment 6 Daniel Quinlan 2003-08-22 11:51:39 UTC 
closing, fixed