Bug 2395 - Removing custom headers?
Summary: Removing custom headers?
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P5 enhancement
Target Milestone: 2.70
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-01 00:30 UTC by Al Smith
Modified: 2003-12-29 13:16 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch patch None Al Smith [NoCLA]
Better patch patch None Al Smith [NoCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Al Smith 2003-09-01 00:30:45 UTC 
In clean_spamassassin_headers(), should spamassassin also attempt
to remove any custom headers that the local installation is about
to add?
Comment 1 Al Smith 2003-09-01 00:31:57 UTC 
Created attachment 1302 [details]
Patch
Comment 2 Al Smith 2003-09-01 00:35:38 UTC 
Created attachment 1303 [details]
Better patch
Comment 3 Malte S. Stretz 2003-09-01 04:00:56 UTC 
Please don't change the milestone -- only devs may :)
Comment 4 Daniel Quinlan 2003-09-06 22:50:31 UTC 
the patch might as well remove the previous delete lines as they won't be
needed if we make this change
Comment 5 Theo Van Dinter 2003-09-06 22:54:11 UTC 
well, I like the idea, but it's only going to be hairy since headers are 
arbitrary now.

I'd just remove the X-Spam-* headers and call it good.
Comment 6 Daniel Quinlan 2003-09-06 22:55:49 UTC 
assigning 2.61 milestone
Comment 7 Daniel Quinlan 2003-09-14 17:42:56 UTC 
> the patch might as well remove the previous delete lines as they won't be
> needed if we make this change

nevermind this, the current patch will be better about deleting
headers since $self->{conf}->{headers_spam} and $self->{conf}->{headers_ham}
may be missing some headers normally added by SpamAssassin.

+1 1303
Comment 8 Theo Van Dinter 2003-09-14 19:24:43 UTC 
+1 1303, I'm still not certain, but think we should look at removing X-Spam-* headers in general.  
But at a minimum, we should remove the headers which the current configuration adds.  so I think 
we can commit 1303, but afterwards move this ticket back to 2.70 for further discussion.
Comment 9 Theo Van Dinter 2003-09-14 20:03:44 UTC 
ok, 1303 committed.  switching back to 2.70 for later discussion.
Comment 10 Duncan Findlay 2003-12-29 22:16:51 UTC 
The code currently deletes X-Spam-*