Bug 2625 - make spamd -m default
Summary: make spamd -m default
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: 2.60
Hardware: Other other
: P4 minor
Target Milestone: 2.70
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-23 17:45 UTC by Justin Mason
Modified: 2004-01-12 15:03 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
implementing this patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2003-10-23 17:45:45 UTC 
Dan Kohn replied offlist re: the spamd -m threads -- 

>>>Do you think setting -m 10 as a default might save problems from naïve users,
>>>while still allowing the rest of us to configure it how we prefer?
>>
>>It already is - in the RC scripts etc.  Problem is, people aren't using 
>>the rc scripts for some reason, or maybe Red Hat aren't taking that.
>
>Any harm in building it into the executable?  It would seem to cut down on
>support complaints.  Otherwise, the default is infinite, and that's not a great
>default.

That's a good point. ;)

People who install from the tarball won't know to limit this until their machine
crashes and burns the first time.  It's in the FAQ, but it's still the #1 issue
people report ("spamassassin killed my server").

The defaults should be sensible -- and this is not a sensible default.
Comment 1 Malte S. Stretz 2003-10-24 05:29:51 UTC 
ACK. Something between 5 and 10 is probably a good default.
Comment 2 Tom Schulz 2003-10-27 06:59:34 UTC 
Note that the value for -m needs to be somewhat smaller than one might think
because of the problem reported in Bug 2568.  That is: if you calculate that
you should be able to set -m to 15, you will need to set it to 10 instead.
I had -m set to 20 and had over 30 spamds running.
Comment 3 Justin Mason 2003-12-04 13:20:16 UTC 
Created attachment 1606 [details]
implementing this

OK, this patch makes -m5 the default, and updates doco appropriately.
(It also renames the vars because they were confusingly named and
accessing $opt{} stuff from the code, which I didn't like.)
Comment 4 Justin Mason 2003-12-04 13:21:40 UTC 
pointing at 2.61, just for comments -- should it go in?   On one side,
it's a very useful fix for a serious problem that hits a lot of people, but on
the other, it's a change in API in the middle of a bugfix cycle.
Comment 5 Duncan Findlay 2003-12-04 16:31:55 UTC 
Subject: Re: [SAdev]  make spamd -m default

> the other, it's a change in API in the middle of a bugfix cycle.

I don't like doing that. -0.5. Also, since we don't have the CLA for
-m IIRC so we may see changes in this code in the near future.
Comment 6 Justin Mason 2003-12-08 22:20:26 UTC 
off you to go to 2.70, so.
Comment 7 Justin Mason 2004-01-13 00:03:18 UTC 
ok, in 2.70.