Bug 2758 - [review] X-Spam-Level header not geting enough stars
Summary: [review] X-Spam-Level header not geting enough stars
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: 2.60
Hardware: Sun Solaris
: P5 minor
Target Milestone: 2.61
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-14 14:56 UTC by Pete Hanson
Modified: 2003-12-01 14:46 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
patch patch None Justin Mason [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pete Hanson 2003-11-14 14:56:29 UTC 
The X-Spam-Level header appears to not get enough stars when handling a high
scoring piece of spam, with a limit of about 50 stars.  Since we have users that
reject mail based on the star count, those that reject at high levels aren't
getting any rejections at all.  Below is a short and sweet test mail
demonstrating an instance where a mail that scores over 100 points is only
receiving 50 stars:

From xyz@officedepot.com  Fri Nov 14 14:48:47 2003
Return-Path: <xyz@officedepot.com>
Received: from smtp.well.com (smtp.well.com [206.14.209.7])
    by mail.well.com (8.12.10/8.12.10) with ESMTP id hAEMmjBJ014482
    for <wolfy@mail.well.com>; Fri, 14 Nov 2003 14:48:45 -0800 (PST)
Received: from well.com (209-193-36-53-cdsl-rb1.nwc.acsalaska.net [209.193.36.53])
    by smtp.well.com (8.12.10/8.12.10) with ESMTP id hAEMm0MW018059
    for wolfy@well.com; Fri, 14 Nov 2003 14:48:20 -0800 (PST)
Date: Fri, 14 Nov 2003 14:48:00 -0800 (PST)
Message-Id: <200311142248.hAEMm0MW018059@smtp.well.com>
From: xyz@officedepot.com
To: wolfy@well.com
Subject: (SPAM 102.50) test
X-Spam-Flag: YES
X-Spam-Checker-Version: SpamAssassin 2.60-the_well_u (1.212-2003-09-23-exp)
    on user.well.com
X-Spam-Report:
    *  2.5 NO_REAL_NAME From: does not include a real name
    *  100 USER_IN_BLACKLIST From: address is in the user's black-list
X-Spam-Status: Yes, hits=102.5 required=5.0 tests=NO_REAL_NAME,
    USER_IN_BLACKLIST autolearn=no version=2.60-the_well_u
X-Spam-Level: **************************************************

test
Comment 1 Theo Van Dinter 2003-11-14 15:18:37 UTC 
this is in the docs, although we should probably make it more obvious:

        _STARS(*)_        one * (use any character) for each score point (50 at most)


I think this is a simple doc fix, so moving to 2.61
Comment 2 Pete Hanson 2003-11-14 15:29:41 UTC 
Why should there be a 50 star limit?  I can see restricting it to prevent
overflows in some MUAs, but 50 is far too cautious.
Comment 3 Theo Van Dinter 2003-11-14 15:36:52 UTC 
Subject: Re: [SAdev]  X-Spam-Level header not geting enough stars

On Fri, Nov 14, 2003 at 03:41:29PM -0800, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> Why should there be a 50 star limit?  I can see restricting it to prevent
> overflows in some MUAs, but 50 is far too cautious.

There was a whole discussion about this, and the decision was made that
"50 is enough to know it's spam".  IIRC, it came down to this part of RFC 2822:

2.1.1. Line Length Limits

   There are two limits that this standard places on the number of
   characters in a line. Each line of characters MUST be no more than
   998 characters, and SHOULD be no more than 78 characters, excluding
   the CRLF.

over 50 chars means the line will likely go more than 78 chars, which
we don't want to do due to the rfc limit.
Comment 4 Justin Mason 2003-11-14 19:03:22 UTC 
Created attachment 1566 [details]
patch

ok, here's the doco fix.  Also note I've indented some lines where the
formatting was wrong otherwise.
Comment 5 Theo Van Dinter 2003-11-25 07:07:39 UTC 
+1

since this is a doco fix, you can just apply it. :)
Comment 6 Justin Mason 2003-12-01 23:46:20 UTC 
done