Bug 2769 - libspamc.c:message_filter() returns the wrong error code
Summary: libspamc.c:message_filter() returns the wrong error code
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
: 3068 (view as bug list)
Depends on:
Blocks: 3208
  Show dependency tree
 
Reported: 2003-11-18 19:51 UTC by Leif Wickland
Modified: 2004-04-27 11:15 UTC (History)
1 user (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Leif Wickland 2003-11-18 19:51:01 UTC
libspamc.c:message_filter() returns the wrong error code if try_to_connect_tcp()
or try_to_connect_unix() return an error.  Rather than return the error code
indicated by those functions' return values, i is returned.  As i will always be
2 at that point in the code, it's a less useful value from a diagnostic
perspective.  

The diff below, which is written against today's CVS snapshot oflibspamc.c,
fixes the problem.

1023c1023
<         return i;
---
>         return rc;
Comment 1 Theo Van Dinter 2004-03-13 16:21:33 UTC
*** Bug 3068 has been marked as a duplicate of this bug. ***
Comment 2 Justin Mason 2004-04-27 19:15:54 UTC
looks like that had been fixed before now; but it was returning just EX_OSERR,
whereas those routines return better errors.  so now they return those.