SA Bugzilla – Bug 2769
libspamc.c:message_filter() returns the wrong error code
Last modified: 2004-04-27 11:15:54 UTC
libspamc.c:message_filter() returns the wrong error code if try_to_connect_tcp() or try_to_connect_unix() return an error. Rather than return the error code indicated by those functions' return values, i is returned. As i will always be 2 at that point in the code, it's a less useful value from a diagnostic perspective. The diff below, which is written against today's CVS snapshot oflibspamc.c, fixes the problem. 1023c1023 < return i; --- > return rc;
*** Bug 3068 has been marked as a duplicate of this bug. ***
looks like that had been fixed before now; but it was returning just EX_OSERR, whereas those routines return better errors. so now they return those.