Bug 2870 - Update to sa-stats.pl
Summary: Update to sa-stats.pl
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Tools (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All other
: P5 normal
Target Milestone: 2.70
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 2802
  Show dependency tree
 
Reported: 2003-12-27 22:11 UTC by Bob Apthorpe
Modified: 2004-01-01 08:35 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Unified diff to sa-stats.pl v1.3 patch None Bob Apthorpe [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Apthorpe 2003-12-27 22:11:17 UTC 
I spent a few hours hacking on sa-stats.pl and here's what's new:* Bug - fixed regex to allow 'user@example.com:1234' usernames* Enhancement - Added dependency on Parse::Syslog; cleans up regex somewhat and should be more portable* Enhancement - Added 'Top 25 Spam Victims' report* Enhancement - Added aggregate stats for bytes processed, time consumed* Enhancement - the debug flag now does something!Aside from that, I refactored some of the code innards.Preliminary tests show it behaves roughly as it did before and it matches the 'user@example.com' test case posted to SA-Talk.diff vs sa-stats.pl 1.3 follows.
Comment 1 Bob Apthorpe 2003-12-27 22:16:26 UTC 
Created attachment 1640 [details]
Unified diff to sa-stats.pl v1.3

I don't usually post diffs - what's the accepted norm for patches (I used 'diff
-u old new')?
Comment 2 Duncan Findlay 2004-01-01 16:59:24 UTC 
I just tried this and it doesn't work at all for me right now because of New
Year's, it seems.

Parse::Syslog really doesnt handle dates very well, especially when dealing with
years. I'll try to fix this. (The code that should do this seems to be broken)
Comment 3 Duncan Findlay 2004-01-01 17:35:17 UTC 
Fixed.