Bug 2896 - Debug code to report unparseable received header is incorrect
Summary: Debug code to report unparseable received header is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 2.61
Hardware: All All
: P5 normal
Target Milestone: 2.62
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on: 2787
Blocks:
  Show dependency tree
 
Reported: 2004-01-04 17:40 UTC by David J. Mellor
Modified: 2004-01-13 14:43 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Proposed patch for bug #2896 patch None David J. Mellor [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David J. Mellor 2004-01-04 17:40:22 UTC 
The code at lines 815 and 822 in the subroutine parse_received_line of
Received.pm is incorrect. The code tests whether the variables $ip and $by are
defined, and if they are not then it prints out a warning message that the
received header could not be parsed. This code will never be invoked because the
$ip and $by variables are initialised to empty strings at the beginning of the
subroutine.
Comment 1 David J. Mellor 2004-01-04 17:41:16 UTC 
Created attachment 1656 [details]
Proposed patch for bug #2896
Comment 2 Justin Mason 2004-01-11 21:08:18 UTC 
patched separately as part of bug 2787
Comment 3 Malte S. Stretz 2004-01-13 16:11:19 UTC 
So this is FIXED?
Comment 4 Malte S. Stretz 2004-01-13 16:12:53 UTC 
Ok, I should have read bug 2787 first ;-)
Comment 5 Justin Mason 2004-01-13 23:43:40 UTC 
fix applied as part of 2787.