Bug 3026 - Red Hat init script improvements
Summary: Red Hat init script improvements
Status: RESOLVED WONTFIX
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other Linux
: P5 trivial
Target Milestone: 2.64
Assignee: Theo Van Dinter
URL:
Whiteboard:
Keywords: spamd
Depends on:
Blocks:
 
Reported: 2004-02-10 09:21 UTC by Ville Skyttä
Modified: 2004-04-24 09:20 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Backslashify description, add processname patch None Ville Skyttä [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ville Skyttä 2004-02-10 09:21:42 UTC 
I will attach a patch containing small improvements to the Red Hat spamd init
script: Wrapped lines should be backslashified in order to allow the description
to be correctly shown in eg. redhat-config-services.  processname is also used
by some init script related UIs.
Comment 1 Ville Skyttä 2004-02-10 09:22:43 UTC 
Created attachment 1762 [details]
Backslashify description, add processname
Comment 2 Gary Funck 2004-02-10 09:36:20 UTC 
Subject: RE:  Red Hat init script improvements


> Backslashify description, add processname


What's the motivation for backslashifying comments?

+# processname: spamd
+# description: spamd is a daemon process which uses SpamAssassin to check \
+#              email messages for SPAM.  It is normally called by spamc \
 #	       from a MDA.

Also, not sure of the rule on this, but should "a MDA" read "an MDA"
instead?
Comment 3 Ville Skyttä 2004-02-10 09:51:11 UTC 
It is not only a comment, it's also a description.  As said in the initial
comment, some GUI programs, eg. redhat-config-services displays it.  Without the
backslashes, it displays:

  spamd is a daemon process which uses SpamAssassin to check

With the backslashes in place, it displays:

  spamd is a daemon process which uses SpamAssassin to check email messages
  for SPAM.  It is normally called by spamc from a MDA.

From the documentation (/usr/share/doc/initscripts-*/sysvinitfiles):

  # description: <multi-line description of service>

        Required.  Several lines of description, continued with '\'
        characters.  The initial comment and following whitespace
        on the following lines is ignored.

FWIW, +1 for "an MDA".
Comment 4 Theo Van Dinter 2004-02-15 12:44:40 UTC 
taking the bug
Comment 5 Theo Van Dinter 2004-02-15 15:30:29 UTC 
ok, applied to head.  thanks!

btw: for future reference for folks: http://www.sensi.
org/~alec/unix/redhat/sysvinit.html explains some of this stuff. :)

I'm putting this in the 2.64 queue in case we do another 2.6 release.
Comment 6 Theo Van Dinter 2004-04-24 17:20:26 UTC 
house cleaning, not doing a 2.64 release, so ...