Bug 3141 - False MIME_HTML_ONLY detection
Summary: False MIME_HTML_ONLY detection
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (Eval Tests) (show other bugs)
Version: 2.63
Hardware: Other Linux
: P5 normal
Target Milestone: 3.1.0
Assignee: Daniel Quinlan
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-08 04:16 UTC by Jean Charles Del
Modified: 2005-01-19 05:07 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Should correctly not detect the sample given in report patch None Jean Charles Del [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean Charles Del 2004-03-08 04:16:27 UTC 
Message-Id: <200403081110.i28BA6hp032185@hiden>
X-Sender: hiden
X-Mailer: QUALCOMM Windows Eudora Pro Version 4.0.2
Date: Mon, 08 Mar 2004 12:12:33 +0100
To: hiden
From: hiden
Subject: ***SPAM*** préparation AG
Mime-Version: 1.0
Content-Type: multipart/alternative;
        types="text/plain,text/html";
        boundary="=====================_11195017==_.ALT"
X-Virus-Scanned: by amavisd-new-20030616-p7 (Debian) at UPJV
X-Spam-Status: Yes, hits=9.8 tagged_above=0.0 required=6.0 tests=BAYES_01,
        FORGED_MUA_EUDORA, HTML_20_30, HTML_MESSAGE, MIME_HTML_ONLY,
        MIME_HTML_ONLY_MULTI
X-Spam-Level: *********
X-Spam-Flag: YES
Status: RO
X-Status: A
Content-Length: 1369
Lines: 56

Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

[...]
Comment 1 Jean Charles Del 2004-03-08 04:18:32 UTC 
Created attachment 1822 [details]
Should correctly not detect the sample given in report

Not tested.
Comment 2 Theo Van Dinter 2004-03-08 19:03:25 UTC 
I definitely don't like the patch, mostly because it opens up the rule to complete abuse.  "Content-Type: 
text/html; text/plain".

I think the correct fix is:

  return 1 if (defined($ctype) && $ctype =~ m@^text/html@i);

on a side note, I don't think this is valid:

        types="text/plain,text/html";

but I'm checking out the RFCs.
Comment 3 Theo Van Dinter 2004-03-08 19:12:03 UTC 
from what I could find in the rfcs, it's valid, but it's up to the MUA to do something, if anything, with it.  
so ignore my statement in the last note.
Comment 4 Daniel Quinlan 2004-08-27 16:59:16 UTC 
moving accuracy and some bugs to 3.1.0 milestone
Comment 5 Daniel Quinlan 2004-08-27 17:17:34 UTC 
more accuracy and performance bugs going to 3.1.0 milestone
Comment 6 Theo Van Dinter 2004-11-05 21:09:02 UTC 
A few things:

1) is this still an issue with 3.0?

2) if so, please attach (via the web page) a sample message which shows the behavior.
Comment 7 Daniel Quinlan 2005-01-18 00:54:18 UTC 
checked in test fix
Comment 8 Daniel Quinlan 2005-01-19 14:07:25 UTC 
closing as FIXED