Bug 3219 - __NMS_CGI_NOT_BUGGY rule broken; fix included
Summary: __NMS_CGI_NOT_BUGGY rule broken; fix included
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P5 normal
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
: 3218 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-26 12:36 UTC by anirvan
Modified: 2004-03-26 03:41 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anirvan 2004-03-26 12:36:40 UTC 
The BUGGY_CGI meta rule is incorrectly matching for mail generated by NMS
FormMail, because NMS FormMail's X-Mailer header format has changed.

The rule for __NMS_CGI_NOT_BUGGY (in 20_meta_tests.cf) should be changed from this:
   
   header __NMS_CGI_NOT_BUGGY      X-Mailer =~ /^NMS FormMail\.pl.*v\d/

to this:

   header __NMS_CGI_NOT_BUGGY      X-Mailer =~ /^NMS FormMail(?:\.pl)?\b.*v\d/

The now-incorrect rule is there in both SA 2.63 and the latest 3.0.0 nightly.

In recent versions of NMS FormMail, the generated X-Mailer header looks like
this (no ".pl"):

   X-Mailer: NMS FormMail 3.12c1

This can be confirmed by looking at lines 2769 and 3233 of
http://nms-cgi.sourceforge.net/formmail_compat-3.12c1/FormMail.pl
Comment 1 anirvan 2004-03-26 12:38:36 UTC 
*** Bug 3218 has been marked as a duplicate of this bug. ***
Comment 2 Justin Mason 2004-03-26 12:41:32 UTC 
this is already fixed in svn.  not sure what version you're looking at. ;)

: jm 1090...; grep NMS_CGI ~/ftp/spamassassin/rules/*.cf
/home/jm/ftp/spamassassin/rules/20_meta_tests.cf:header __NMS_CGI_NOT_BUGGY    
 X-Mailer =~ /^NMS FormMail/
/home/jm/ftp/spamassassin/rules/20_meta_tests.cf:meta BUGGY_CGI                
(__BUGGY_CGI && !__NMS_CGI_NOT_BUGGY)