Bug 3275 - __FROM_JUST_NUMBER broke since 2.63
Summary: __FROM_JUST_NUMBER broke since 2.63
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-15 15:59 UTC by Daniel Quinlan
Modified: 2004-04-15 13:22 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
example message hit by 2.63 but not SVN text/plain None Daniel Quinlan [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Quinlan 2004-04-15 15:59:21 UTC 
The rule is the same, but From:addr or something else broke since 2.63.
Comment 1 Daniel Quinlan 2004-04-15 16:02:44 UTC 
Created attachment 1903 [details]
example message hit by 2.63 but not SVN
Comment 2 Theo Van Dinter 2004-04-15 21:11:34 UTC 
<grrr>

for some reason, From:addr is all messed up:

>> From:addr = "Allied Marketing Promotions
Comment 3 Theo Van Dinter 2004-04-15 21:13:18 UTC 
it's because of:

        s/,.*$//;                       # multiple addrs on one line? remove all but first

<grrr>
Comment 4 Theo Van Dinter 2004-04-15 21:22:06 UTC 
ok, I moved the "remove multiple addr" replacement to the end of the :addr code.  it was originally 
there, then moved up in the code to simplify the work being done, but it obviously didn't take into 
account that "," was allowed in the real name quoted area. :(

r10039
Comment 5 Daniel Quinlan 2004-04-15 22:33:15 UTC 
Subject: Re:  __FROM_JUST_NUMBER broke since 2.63

bugzilla-daemon  <bugzilla-daemon@bugzilla.spamassassin.org> writes:

> ok, I moved the "remove multiple addr" replacement to the end of the
> :addr code.  it was originally there, then moved up in the code to
> simplify the work being done, but it obviously didn't take into
> account that "," was allowed in the real name quoted area. :(

Should it really remove multiple addresses?  It seems like we should be
putting each address on a separate line and doing a /m match for all
those rules or something like that.

- Daniel