Bug 3307 - Basic lint test fails with reference to nonexistent rule
Summary: Basic lint test fails with reference to nonexistent rule
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (Eval Tests) (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Linux
: P5 normal
Target Milestone: 3.1.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-25 23:05 UTC by Conrad Heiney
Modified: 2004-04-26 13:10 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Heiney 2004-04-25 23:05:13 UTC 
t/basic_lint................warning: score set for non-existent rule
HTML_FONT_FACE_ODD
        Not found: anything =   
# Failed test 1 in t/SATest.pm at line 493
Comment 1 Daniel Quinlan 2004-04-26 00:51:28 UTC 
fixed

This one lint rule is a real pain.  Extra scores are about as harmless as they
get.
Comment 2 Fred T 2004-04-26 14:01:40 UTC 
The lint rule should help when updating to 3.0.0, it'll help me clean out un-
needed score statements for all the rules which changed name from 2.63 to 
3.0.0 ;)

They are probably harmless, but I'm human and I've made mistakes scoring a rule 
in the past, I thought I knew the exact name, turns out I was wrong.  It will 
also help those of us like myself and Robert Menschel who put a lot of time 
into scoring the stock rules higher for a higher threshold.  See: 
http://www.exit0.us/index.php/RM_DefaultScoreChanges

It looks like he spent a lot of time doing all that!
Comment 3 Bob Menschel 2004-04-26 21:10:50 UTC 
Likewise, those of us who do a lot of custom rulework often do have 
typographical errors.  Yes, it's most important to --lint errors in the regex 
expressions, but a typo in the rule name of a score or description line is 
also important.  Mistype the rule name in a description line, and you don't 
get a description when the rule is matched. Mistype the rule name in a score 
line, and you get a default score, not the score you intended (which can be 
significant, if the intended score was 0.2 or 3.0). I would appreciate a --
lint which warned of these types of errors. 
Bob Menschel