Bug 3346 - make not checking for Storable module/spamd tests passed without it
Summary: make not checking for Storable module/spamd tests passed without it
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamc/spamd (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: Future
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on: 4305
Blocks:
  Show dependency tree
 
Reported: 2004-05-03 15:48 UTC by Kelsey Cummings
Modified: 2005-05-10 11:40 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kelsey Cummings 2004-05-03 15:48:09 UTC 
make doesn't check for the module and 'make test' doesn't fail.

Sorry if this is already attached to another bug report.
Comment 1 Theo Van Dinter 2004-05-03 16:06:23 UTC 
Subject: Re:  New: make not checking for Storable module/spamd tests passed without it

On Mon, May 03, 2004 at 03:48:10PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> make doesn't check for the module and 'make test' doesn't fail.
> 
> Sorry if this is already attached to another bug report.

Right.  Storable isn't required, so there's no check for it.
Comment 2 Kelsey Cummings 2004-05-03 16:15:01 UTC 
Subject: Re:  make not checking for Storable module/spamd tests passed without it

On Mon, May 03, 2004 at 04:06:24PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> http://bugzilla.spamassassin.org/show_bug.cgi?id=3346
> 
> 
> 
> 
> 
> ------- Additional Comments From felicity@kluge.net  2004-05-03 16:06 -------
> Subject: Re:  New: make not checking for Storable module/spamd tests passed without it
> 
> On Mon, May 03, 2004 at 03:48:10PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> > make doesn't check for the module and 'make test' doesn't fail.
> > 
> > Sorry if this is already attached to another bug report.
> 
> Right.  Storable isn't required, so there's no check for it.

What features require it?  When I tried starting spamd it complained and
exited.
Comment 3 Theo Van Dinter 2004-05-03 16:21:12 UTC 
Subject: Re:  make not checking for Storable module/spamd tests passed without it

On Mon, May 03, 2004 at 04:15:02PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> What features require it?  When I tried starting spamd it complained and
> exited.

It's in the INSTALL doc. :)

But basically, spamd needs it if you're running it in a way that will
have it changing user state back and forth.

If you run with -u, for instance, the spamd processes never have to load
new configs per-user, etc, so Storable isn't required to backup/restore
the config per message.
Comment 4 Daniel Quinlan 2005-03-30 01:09:09 UTC 
move bug to Future milestone (previously set to Future -- I hope)
Comment 5 Justin Mason 2005-05-05 00:13:39 UTC 
bug 4305 would fix this
Comment 6 Justin Mason 2005-05-10 19:40:12 UTC 
fixed by removal of Storable ;)