Bug 3431 - [review] feature to add hostname of the remote client to the Summary line generated by spamd
Summary: [review] feature to add hostname of the remote client to the Summary line gen...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P3 enhancement
Target Milestone: 3.0.0
Assignee: Malte S. Stretz
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 3208
  Show dependency tree
 
Reported: 2004-05-26 12:13 UTC by Malte S. Stretz
Modified: 2004-05-29 09:05 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
patch against spamd.raw, PerMsgStatus.pm and Conf.pm patch None Malte S. Stretz [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2004-05-26 12:13:59 UTC 
Today I set up a central spamd instance which is queried from several other 
clients. While working on this I noticed that it could come in very handy if 
it was possible to see in the X-Spam-Summary line which host was the one which 
actually queried spamd. 
 
Writing this feature was a thing of a few minutes, patch follows. Would be 
cool if it could go into 3.0 so I don't have to maintain the patch till 3.1 :)
Comment 1 Malte S. Stretz 2004-05-26 12:16:00 UTC 
Created attachment 1973 [details]
patch against spamd.raw, PerMsgStatus.pm and Conf.pm

The patch is relatively trivial -- the $start vs. $start_time stuff is just a
renamed variable/parameter.
Comment 2 Malte S. Stretz 2004-05-26 16:44:46 UTC 
Actually, what's missing in the patch is a default value for the stuff. No big 
change though.
Comment 3 Malte S. Stretz 2004-05-27 13:22:31 UTC 
For 3.0?
Comment 4 Justin Mason 2004-05-27 19:06:33 UTC 
yeah, throw it in.  Are we in R-T-C mode?  I don't think so yet...

(just in case: +1)
Comment 5 Theo Van Dinter 2004-05-27 19:56:13 UTC 
Subject: Re:  [review] feature to add hostname of the remote client to the Summary line generated by spamd

On Thu, May 27, 2004 at 07:06:34PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> yeah, throw it in.  Are we in R-T-C mode?  I don't think so yet...

we're CTR in general, but enhancements need to be voted on since we're
trying to keep the ticket queue from getting new tickets.
Comment 6 Justin Mason 2004-05-27 20:05:56 UTC 
ok, +1
Comment 7 Theo Van Dinter 2004-05-27 20:08:31 UTC 
yeah, I don't see an issue.  +1
Comment 8 Malte S. Stretz 2004-05-28 15:27:45 UTC 
Committed with default values.
Comment 9 Justin Mason 2004-05-28 17:42:39 UTC 
I spoke too soon -- I was getting test failures, in the spamd tests.   this
patch wasn't fully applied -- it is now in 20560.
Comment 10 Malte S. Stretz 2004-05-29 17:05:57 UTC 
I feared this. I explicitly told svn to apply the three files but in the 
commit log there were only two of them. Though it told me my codebase was 
up-to-date. Very weird.