Bug 3537 - [review] addition of idv.hk, gov.hk, edu.hk to TWO_LEVEL_DOMAINS
Summary: [review] addition of idv.hk, gov.hk, edu.hk to TWO_LEVEL_DOMAINS
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 trivial
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-24 01:42 UTC by Yusuf Goolamabbas
Modified: 2004-06-24 04:53 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
basically the same patch, just done up slightly differently patch None Theo Van Dinter [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Goolamabbas 2004-06-24 01:42:48 UTC 
Hi, The following simple patch adds idv.hk, gov.hk, edu.hk to the list of
TWO_LEVEL_DOMAINS in registrar boundaries

.hk is handled by the existing mechanism

The complete list of suffixes handled by HKDNR is found here
Request that this be applied before SA 3.0 release


https://www.hkdnr.net.hk/instructions/new_domain.html

--- RegistrarBoundaries.pm.orig 2004-06-24 16:06:51.582514192 +0800
+++ RegistrarBoundaries.pm      2004-06-24 16:08:14.170958840 +0800
@@ -311,6 +311,9 @@
   com\.hk |
   net\.hk |
   org\.hk |
+  gov\.hk |
+  edu\.hk |
+  idv\.hk |
   co\.hu |
   org\.hu |
   info\.hu |
Comment 1 Jeff Chan 2004-06-24 01:47:44 UTC 
Thanks, I've added those to the SURBL two level domain list also.
Comment 2 Theo Van Dinter 2004-06-24 08:22:15 UTC 
it's trivial enough that I don't have a problem going into 3.0.

BTW: we generally ignore any patches not attached to the ticket (no cut-paste!)
Comment 3 Theo Van Dinter 2004-06-24 08:25:38 UTC 
Created attachment 2063 [details]
basically the same patch, just done up slightly differently

I added in the URI for the .hk information, and also did the diff from the mail
SA directory instead of lib/Mail/SpamAssassin/Util so it's easier to apply.
Comment 4 Theo Van Dinter 2004-06-24 08:30:02 UTC 
changing summary to review state
Comment 5 Michael Parker 2004-06-24 08:34:23 UTC 
+1
Comment 6 Daniel Quinlan 2004-06-24 08:51:24 UTC 
Subject: Re:  [review] addition of idv.hk, gov.hk, edu.hk to TWO_LEVEL_DOMAINS

+1
Comment 7 Justin Mason 2004-06-24 12:52:28 UTC 
+1
Comment 8 Theo Van Dinter 2004-06-24 12:53:50 UTC 
committed to head.  r22081.  thanks. :)