Bug 3628 - [review] 'make test' fails if Storable is not installed
Summary: [review] 'make test' fails if Storable is not installed
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-22 20:25 UTC by Justin Mason
Modified: 2004-07-28 23:03 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch File patch None Michael Parker [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2004-07-22 20:25:14 UTC 
t/spamd_allow_user_rules.spamd start failed: log: logging enabled:
        facility: stderr
        socket:   file
        output:   stderr
logging to stderr disabled: already debugging to stderr
debug: SpamAssassin version 3.0.0-pre3
debug: Score set 0 chosen.
debug: no Storable module found
Required module Storable not found!


Maybe you need to kill a running spamd process?

t/spamd_allow_user_rules.NOK 3  Not found: myfoo =  1.0 MYFOO
t/spamd_allow_user_rules.FAILED tests 1, 3-4
        Failed 3/5 tests, 40.00% okay



not a pre3 blocker IMO, but something we have to fix before the main release.

To be honest, I think we should just require Storable in Makefile.PL...
Comment 1 Justin Mason 2004-07-22 20:25:36 UTC 
milestone
Comment 2 Michael Parker 2004-07-22 20:31:55 UTC 
I'm +1 for requiring Storable, or we could not run that test if it's not installed.

I think it's failing now because virtual-config-dir was just added to the
copy_config stuff.
Comment 3 Theo Van Dinter 2004-07-22 20:35:40 UTC 
Storable shouldn't be required.  There's already code in M::SA to check for it, so we can easily add in a 
check.
Comment 4 Malte S. Stretz 2004-07-23 06:58:19 UTC 
I don't have Storable installed and for me it works...
Comment 5 Malte S. Stretz 2004-07-23 07:00:06 UTC 
Actually, got to correct that. I don't have Storable manually installed but it 
seems like its included in Perl 5.8.2.
Comment 6 Daniel Quinlan 2004-07-23 11:32:17 UTC 
I'd prefer to avoid adding a new module requirement if it's reasonably
possible.
Comment 7 Michael Parker 2004-07-23 11:34:59 UTC 
*** Bug 3629 has been marked as a duplicate of this bug. ***
Comment 8 Michael Parker 2004-07-27 23:08:21 UTC 
Created attachment 2188 [details]
Patch File

This patch takes the easy approach of a quick little require Storable check.  I
didn't use the method in SpamAssassin.pm because a) it's private and b) we'd
have to create an SA object to make the call.
Comment 9 Michael Parker 2004-07-27 23:08:51 UTC 
Setting to review state.
Comment 10 Theo Van Dinter 2004-07-27 23:55:46 UTC 
+1
Comment 11 Justin Mason 2004-07-28 23:29:54 UTC 
+1
Comment 12 Michael Parker 2004-07-29 07:03:10 UTC 
Committed revision 30927.