Bug 3638 - Make test errors under Windows "Can't open ../spamd/spamd"
Summary: Make test errors under Windows "Can't open ../spamd/spamd"
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Regression Tests (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Windows XP
: P5 normal
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on: 3639
Blocks:
  Show dependency tree
 
Reported: 2004-07-27 17:27 UTC by Sidney Markowitz
Modified: 2004-08-03 14:31 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status
patch t/SATest.pm to fix bug as described in previous comments patch None Sidney Markowitz [HasCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Sidney Markowitz 2004-07-27 17:27:41 UTC
I introduced a bug in t/SATest.pm with the checkin for rev 23108 for bug 3573
that results in error messages, but not failed tests, when running make test
under Windows.

That checkin calls spamd and spamc to see if their version output includes SSL.
The correct behavior is not to call spamd if it does not exist (e.g., under
Windows), not to call spamc if spamc tests are disabled, and to run SSL tests
even if there is no local spamd as long as spamc SSL is known to be available.

Attaching a patch.

While looking at this I noticed that I introduced another bug with the checkin
for  bug 3541 that causes the spamc tests to be skipped under windows when the
test scripts are run from a make test in the trunk directory. I'll file that as
a separate bug report, but this fix only makes sense when that is fixed too.
I'll cross-reference to the bug number after I file it.
Comment 1 Sidney Markowitz 2004-07-27 19:44:17 UTC
Created attachment 2185 [details]
patch t/SATest.pm to fix bug as described in previous comments
Comment 2 Sidney Markowitz 2004-08-03 22:31:32 UTC
fix commited rev 35673