Bug 3644 - [review] ()'s in rewrite_header Subject are changed to []'s
Summary: [review] ()'s in rewrite_header Subject are changed to []'s
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other FreeBSD
: P5 minor
Target Milestone: 3.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-28 15:17 UTC by Lewis Butler
Modified: 2004-07-29 09:26 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
leave parens in Subject rewrite patch None Theo Van Dinter [HasCLA]
same as last patch, but changes doco appropriately patch None Theo Van Dinter [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Butler 2004-07-28 15:17:51 UTC 
rewrite_header Subject (Spam _HITS_) results in [Spam _HITS_] instead, breaking consistancy with SA 
previous version (and two years of spam tagged email).

This also causes confusion because []'s are often use to enclose the name of a mailing list.
Comment 1 Theo Van Dinter 2004-07-28 15:24:19 UTC 
ok, we had a discussion about this on one of the sa lists.  the behavior was specifically written in, but 
no one seemed to come up a reason to do it beyond: it may be good in from and to to avoid "((" "))"...  
so in subject, we can probably skip that.
Comment 2 Theo Van Dinter 2004-07-28 15:29:37 UTC 
Created attachment 2193 [details]
leave parens in Subject rewrite
Comment 3 Theo Van Dinter 2004-07-28 15:34:17 UTC 
Created attachment 2194 [details]
same as last patch, but changes doco appropriately

oops, forgot the doco update in the last patch. :(
Comment 4 Justin Mason 2004-07-28 23:32:59 UTC 
+1
Comment 5 Michael Parker 2004-07-29 08:16:25 UTC 
+1
Comment 6 Theo Van Dinter 2004-07-29 17:26:32 UTC 
committed.  r30954