Bug 3910 - [review] slackware rc.d script fails
Summary: [review] slackware rc.d script fails
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: 3.0.0
Hardware: Other Linux
: P5 normal
Target Milestone: 3.0.1
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-19 08:48 UTC by Rodolfo Borges
Modified: 2004-10-20 00:33 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch to fix slackware init script patch None Henry Stern [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodolfo Borges 2004-10-19 08:48:28 UTC 
the rc.d script provided for slackware fails to stop (and restart) spamd.
for this to work here, I had to change the 'stop' method from

#        $KILL -9 `cat $PIDFILE`
#       /bin/rm $PIDFILE

to

        $KILL `/sbin/pidof $PNAME`

and on the 'restart' method, I added a 'sleep 1s' between stop and start
Comment 1 Henry Stern 2004-10-19 11:34:22 UTC 
I tested this on a Slackware 10 box.  The script dies on line 41, "/bin/rm
$PIDFILE" because spamd seems to unlink its pid file when it is killed.  Also,
spamd was leaving zombie children when killed with a SIGKILL.

I changed the signal that kill sends to spamd and added the -f flag to rm.  I
also did a bit of cosmetic cleanup.
Comment 2 Henry Stern 2004-10-19 11:34:46 UTC 
Created attachment 2465 [details]
Patch to fix slackware init script
Comment 3 Daniel Quinlan 2004-10-19 11:44:02 UTC 
+1 on Henry's patch

I don't think we need the author tag, though.  ;-)
Comment 4 Theo Van Dinter 2004-10-19 11:54:14 UTC 
+1  sure.
Comment 5 Rodolfo Borges 2004-10-19 12:02:46 UTC 
I tested the patch on my production server, and it seems to work fine.

I'm new to bugzilla. As the bug submitter, do I have to take any action?
Checking this 'Resolve bug, changing resolution to FIXED' bellow, for instance?
Comment 6 Theo Van Dinter 2004-10-19 12:11:25 UTC 
Subject: Re:  [review] slackware rc.d script fails

On Tue, Oct 19, 2004 at 12:02:48PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> I'm new to bugzilla. As the bug submitter, do I have to take any action?
> Checking this 'Resolve bug, changing resolution to FIXED' bellow, for instance?

No, one of the developers will apply the patch to the code, then close the
ticket when that's complete.

bug submitters pretty much only ever close a bug if they figure out that what
they reported wasn't a bug (pebkac or whatever...)
Comment 7 Henry Stern 2004-10-20 08:33:52 UTC 
Committed patch to stable and head.