Bug 398 - base64 decoding patch
Summary: base64 decoding patch
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: 2.20
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: Craig Hughes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-04 17:17 UTC by Daniel Rogers
Modified: 2002-06-04 14:40 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
Patch for base64 decoding patch None Daniel Rogers [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rogers 2002-06-04 17:17:27 UTC
Comment 1 Daniel Rogers 2002-06-04 17:18:48 UTC 
Blah.

Just a little patch that does two things:

1. Makes it so only three lines of base64 are needed, instead of five.  You can
fit a lot of spam in to five lines.

2. Strips \r out of the buffer.  mimedefang has \r's in the message before
passing it to SA.  Everything else is fine with this , but it makes the base64
decoding unhappy.

Dan.
Comment 2 Daniel Rogers 2002-06-04 17:19:14 UTC 
Created attachment 145 [details]
Patch for base64 decoding
Comment 3 Craig Hughes 2002-06-04 22:40:11 UTC 
Is this the right place to chop out the \r's?  Apparently MIMEDefang->SA->Razor is also broken 
because of the spurious \r's -- maybe we should chop them out of the raw message more or less as 
soon as we read it in?

In any case, I've applied this patch, and committed.