Bug 4040 - 30_text_de.cf brings up error message
Summary: 30_text_de.cf brings up error message
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.0.1
Hardware: All All
: P4 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
: 4007 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-12-17 07:22 UTC by Florian Effenberger
Modified: 2005-03-15 00:23 UTC (History)
2 users (show)



Attachment Type Modified Status Actions Submitter/CLA Status
This patch allows longer lines for non-english locales patch None Felix Schwarz [NoCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Effenberger 2004-12-17 07:22:48 UTC
The 30_text_de.cf rule brings up an error message with -D --lint:

warning: description for PORN_URL_SEX is over 50 chars
(and so on for a lot of other translations)
Comment 1 Michael Parker 2004-12-17 08:06:18 UTC
Yeah, we need some translators I guess to get the descriptions down below the limit.

We have this on more than one set of translations.

*** This bug has been marked as a duplicate of 4007 ***
Comment 2 Klaus Heinz 2004-12-17 18:18:44 UTC
Subject: Re:  30_text_de.cf brings up error message

bugzilla-daemon@bugzilla.spamassassin.org wrote:

> Yeah, we need some translators I guess to get the descriptions down below
> the limit.

I do not agree with this conclusion. As I already commented on another
bug ([Bug 3085] TRACKER_ID rule not very useful) some languages simply
use longer words/sentences (on average) than English.
Having no short and accurate translations of many/most computer related
English terms complicates the matter.

> We have this on more than one set of translations.

IMO, this really indicates the limit of 50 characters is too low.

I count 823 German rule description (788 unique) and 242 of them have a
length of > 50 characters, with a maximum length of 70. This was the
result of cutting away as much as I could for the release of 3.0 (I
_did_ test with --lint before I submitted the descriptions).
I doubt you can bring them _all_ under the limit of 50 characters.

ciao
     Klaus

Comment 3 Justin Mason 2004-12-17 18:39:28 UTC
Personally, I would be very happy to see the length restrictions on descriptions
and rule names disappear.  IMO, they were a mistake:

1. they have resulted in less readable names and descriptions, even in english.
2. lint errors from this is one of the top 5 FAQs.
3. we have a hard enough time getting descriptions for other languages, without
this limitation making it harder for translators.

How hard would it be to fix the report code to just deal with it?
Comment 4 Loren Wilton 2004-12-17 20:11:16 UTC
Subject: Re:  30_text_de.cf brings up error message

>I do not agree with this conclusion. As I already commented on another
>bug ([Bug 3085] TRACKER_ID rule not very useful) some languages simply
>use longer words/sentences (on average) than English.
>Having no short and accurate translations of many/most computer related
>English terms complicates the matter.

Some standard rules for internationalizing software:

Creating Application Messages
When you create messages in your application, English text strings are usually shorter than equivalent text strings in other languages. The following table shows the additional average growth for strings, based on their initial length.

English length (in characters) Additional growth for localized strings 
1 to 4 100% 
5 to 10 80% 
11 to 20 60% 
21 to 30 40% 
31 to 50 20% 
over 50 10% 


At a glance, a 50 byte English string should be allowed to grow to at least 60 bytes in other languages.  In this case I'd personally allow it to grow to 70 characters at least.  

I'm aware of the original goal of keeping the description and score on a single 80-character line.  However, there are cases right now where that doesn't work, and SA contains code to wrap long descriptions.  I think trying to enforce an 80 byte line limit (especially on translations) is beating a horse that was never alive in the first place, and is certainly dead now.

In fact the 50 byte limit is a pain even for English descriptions in many cases.

Comment 5 Daniel Quinlan 2004-12-18 00:45:20 UTC
Subject: Re:  30_text_de.cf brings up error message

I'd accept a patch to remove the restriction for lang != en (standard
disclaimers apply).

Daniel

Comment 6 Duncan Findlay 2005-01-01 13:44:00 UTC
Hmmm.... Duplicate but of what?
Comment 7 Michael Parker 2005-01-05 08:12:33 UTC
It is a dup of 4007, granted all of the interesting discussion about fixing the
two bug happened here, instead of there.  I'll close that one as a dup so we
don't lose the discussion.
Comment 8 Michael Parker 2005-01-05 08:13:24 UTC
*** Bug 4007 has been marked as a duplicate of this bug. ***
Comment 9 Felix Schwarz 2005-03-15 04:09:18 UTC
Created attachment 2700 [details]
This patch allows longer lines for non-english locales
Comment 10 Felix Schwarz 2005-03-15 04:31:47 UTC
After applying my patch there are still some errors with descriptions for
non-existent rules. I opened a separate bug for these things in order to keep
the discussion focussed on the line length issue.

-> Bug 4139
Comment 11 Felix Schwarz 2005-03-15 04:33:25 UTC
sorry for spamming but it is bug 4193.
Comment 12 Justin Mason 2005-03-15 09:23:28 UTC
this is fixed in 3.1.0 svn trunk; the limit is now gone, and wrapping code is
used to deal with overlong descriptions.