Bug 4148 - Either sa-learn --folders doesn't work or the man-page doesn't
Summary: Either sa-learn --folders doesn't work or the man-page doesn't
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 3.0.2
Hardware: PC Linux
: P5 minor
Target Milestone: 3.1.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-22 08:11 UTC by BigSmoke
Modified: 2005-03-11 10:59 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description BigSmoke 2005-02-22 08:11:55 UTC
The sa-learn man page specifies the file argument for folders to hold one folder
per line with an optional ham: or spam: prefix.

However, Mail::SpamAssassin::ArchiveIterator.pm, on line 413, expects three 
fields: $class, $format, and $rawloc. $format isn't even mentioned in the man
page and it would appear that the ham:/spam: prefixes don't seem all that optional
either. To make this line work, I need to change the lines in the --folders file
to something like "ham:dir:~/.maildir/My dir/cur/".

To fix it, I simply changed line 413 into:
  my ($class, $rawloc) = split(/:/, $target, 3);
  my $format = 'detect';  

I haven't attached a diff, because I modified the original file ...
Comment 1 Theo Van Dinter 2005-02-22 08:55:56 UTC
looking at the code, we need to modify "ham:path" to be "ham::path", or document
that and that "ham:dir:path" is what we really want.
Comment 2 Theo Van Dinter 2005-03-11 19:59:12 UTC
fixed in trunk, r157226.  documentation makes it more clear, etc.